Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead link in documentation #53348

Closed
GHTaarn opened this issue Feb 15, 2024 · 7 comments
Closed

Dead link in documentation #53348

GHTaarn opened this issue Feb 15, 2024 · 7 comments
Labels
docs This change adds or pertains to documentation good first issue Indicates a good issue for first-time contributors to Julia

Comments

@GHTaarn
Copy link
Contributor

GHTaarn commented Feb 15, 2024

On https://docs.julialang.org/en/v1/stdlib/Test/

the link to https://pkgdocs.julialang.org/dev/creating-packages/#Adding-tests-to-the-package does not work. The link has the text "adding tests to your Julia Package"

@sjkelly
Copy link
Contributor

sjkelly commented Feb 15, 2024

It points to dev whereas the link should probably be the v1 link that works here: https://pkgdocs.julialang.org/v1/creating-packages/#Adding-tests-to-the-package

@GHTaarn
Copy link
Contributor Author

GHTaarn commented Feb 15, 2024

Thank you, that looks correct

@ViralBShah ViralBShah added docs This change adds or pertains to documentation good first issue Indicates a good issue for first-time contributors to Julia labels Feb 16, 2024
@ViralBShah
Copy link
Member

Submit a PR?

@areebfazli
Copy link

Hello,
Is this issue closed?
Or can I work on it?

@sjkelly
Copy link
Contributor

sjkelly commented Feb 29, 2024 via email

@areebfazli
Copy link

The problem is not as simple as it seems because in the file index.md the link is using @ref as a reference. I can hardcode the working link https://pkgdocs.julialang.org/v1/creating-packages/#Adding-tests-to-the-package but I don't think that's the optimal solution as the other link on the page with the text "read about more here" has the same issue.
The proper way to fix this is to change the definition of @ref but I cannot the location of that
Can someone guide me about this?

Capture

@xlxs4
Copy link
Contributor

xlxs4 commented Jul 13, 2024

I think this can be closed; cref. https://github.com/JuliaLang/julia/pull/53509/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation good first issue Indicates a good issue for first-time contributors to Julia
Projects
None yet
Development

No branches or pull requests

6 participants