-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename Uint => UInt, etc. ? #8905
Comments
FWIW, I remember that when I discovered Julia I found |
It's kind of the thing you just take for granted, but I have often seen if can_deprecate_types_with_proper_warning()
return +1
else
return -10
end A nice way to do deprecation with warnings would also greatly benefit the |
I agree, |
+1 |
In the same vein: |
+1 for changing On Wed, Nov 5, 2014 at 7:15 AM, Nicolas Tessore notifications@github.com
|
Although Regex is technically an abbreviation its quite standard to capitalize it this way in a variety of languages. |
Another +1 |
+1, bitten by this one several times. |
+10000 for more consistent capitalization |
Julia 0.4: the spelling release. It would be good to have more useful error messages in 0.4 for people who use the old names. |
We could have a Dict of deprecated names, and use it in the |
Is there any way deprecations could be hooked into the lazy resolution of names from |
Yes that could probably be done. |
Having the ability to deprecate bindings would be a huge deal. With that we can basically do almost any kind of deprecation pretty painlessly. |
In any case, this rename at least seems popular. @JeffBezanson, @ViralBShah – do you guys have opinions? You guys have been living with these spellings for the longest. I didn't really notice how much better |
I'm fine with this. |
rename Uint => UInt (closes #8905)
Related: Cint and other C types. |
Here we go again! Luckily that rename isn't as big. |
Oh, the CInt fix will be beautiful. :) |
The thing about the |
Both of those seem much more readable to me. I kind of like the Base.C idea. |
+1 to C.int On Thu, Nov 6, 2014 at 9:55 AM, John Myles White notifications@github.com
|
I don't like the |
Hi Ivar, any particular reason you don't like that idea? I feel that separating such things out into their own namespace removes Cheers, Kevin On Thu, Nov 6, 2014 at 1:53 PM, Ivar Nesje notifications@github.com wrote:
|
I'm not really sure, and it I'll be fine whatever. It is a breaking change and we should be careful with those. The names isn't hugely valuable for other usages. It also feels weird to put part of the C-API in a module. I might like it better if the plan was to also move |
Would you then name it |
I'm also -1 on this. No name is perfect. Better to just leave pandora's box closed. |
@Jutho Yes, for example, but I still think the current names are good enough. Calling C feels more native that way. |
I like the proposed new spellings. Like you said, we should have thought of this 5 years ago! Better late than never. |
Wouldn't having an exported module called |
@tkelman c'est comme C, comme ça |
That definitely got a chuckle out of me. The nice thing about |
When thinking about breaking changes to the C-API we should also look at the bug in 4b4565f. Can we have something like a Can we also get rid of the ugly mix of normal types and special |
Using a namespace would allow for interfaces with other languages to follow the same pattern, which is nice. But would |
Since |
Don't we really want as few "special" things as possible in the language? |
I kind of like it, but on the other hand variable-name conflicts are likely to be common. All my covariance matrices are named |
It could remain unexported, so that you'd have to run |
The current @StefanKarpinski, "littering the namespace" is only really a problem if there is likely to be a conflict, but there is much more likely to be a conflict with |
There's not really any way to avoid having ccall be special.
|
That's correct. The specialness let us add some very nice functionality like I'm slightly against a However having |
What is special with It does some lookup compile time as a performance optimization, but in all other cases where we need compile time specialization we use |
See I suppose |
I was watching a presentation on Swift, which has eerily similar names for basic numeric types – except that unsigned integer types are capitalized as
UInt
rather thanUint
,UInt64
rather thanUint64
, etc., which strikes me as possibly a more pleasant and consistent capitalization on the theory thatUInt
is short forU(nsigned )Int(eger)
. It also has the virtue that changing a type fromInt
andUInt
is just a matter of adding a letter instead of replacing a letter and adding a letter.To be filed under things I should have brought up five years ago.
The text was updated successfully, but these errors were encountered: