compilecache should use same path as require, and treat cache as stale if path changes #12725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
force-pushed
the
precompile_path
branch
from
1aec581
to
b737a04
Compare
stevengj
changed the title
| static jl_value_t *unique_func = NULL; | ||
| if (!unique_func) | ||
| unique_func = jl_get_global(jl_base_module, jl_symbol("unique")); | ||
| jl_array_t *udeps = deps && unique_func ? (jl_array_t *) jl_apply((jl_function_t*)unique_func, (jl_value_t**)&deps, 1) : NULL; |
There was a problem hiding this comment.
although I think it's safe here since we don't allocate any other memory before being done with this array, I'd be more comfortable if we rooted it anyway. That way it wont blow up if someone changes the code later to allocate something.
There was a problem hiding this comment.
Thanks, I've added JL_GC_PUSH/JL_GC_POP.
stevengj
force-pushed
the
precompile_path
branch
2 times, most recently
from
b22d195
to
19e1737
Compare
| jl_array_t *udeps = deps && unique_func ? (jl_array_t *) jl_apply((jl_function_t*)unique_func, (jl_value_t**)&deps, 1) : NULL; | ||
|
|
||
| if (udeps) { | ||
| JL_GC_PUSH(udeps); |
|
LGTM. |
stevengj
force-pushed
the
precompile_path
branch
from
19e1737
to
bbda02e
Compare
…d .ji files should be considered stale if the module is no longer found at the same path
stevengj
force-pushed
the
precompile_path
branch
from
bbda02e
to
4b24670
Compare
|
Rebased after #12723. |
stevengj
added a commit
that referenced
this pull request
Aug 21, 2015
compilecache should use same path as require, and treat cache as stale if path changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #12722:
Base.compilecacheshould use same path asrequire(in particular, it shouldn't look in.if that is not inLOAD_PATH). Also,.jifiles should be considered stale if the module is no longer found at the same path as when the.jifile was compiled.