fail to load modules if precompilation fails #12723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
force-pushed
the
detect_precompile_errors
branch
from
ccba1e9
to
3bb13b4
Compare
stevengj
added a commit
to stevengj/julia
that referenced
this pull request
Aug 21, 2015
…d .ji files should be considered stale if the module is no longer found at the same path
|
Seems to be hanging on Windows? @tkelman, any clue on what might be going on here? |
|
possibly having to do with the redirection, same as in #12519 |
|
Ah, okay, I'll eliminate the redirection and wait for #12519 to resolve that problem on Windows. |
… .ji file exists (fixes JuliaLang#12720)
stevengj
force-pushed
the
detect_precompile_errors
branch
from
3bb13b4
to
ed2f8ba
Compare
|
+1. Ok to merge? Unfortunately looks like it will conflict with #12725. |
stevengj
added a commit
that referenced
this pull request
Aug 21, 2015
fail to load modules if precompilation fails
This was referenced Nov 24, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #12720: if precompilation fails for any reason, we should fail to load the module, even if an otherwise-valid (but stale)
.jifile exists.