Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Eliminate backtrace display when testing __precompile__() #12519

Closed
wants to merge 1 commit into from
Closed

WIP: Eliminate backtrace display when testing __precompile__() #12519

wants to merge 1 commit into from

Conversation

ScottPJones
Copy link
Contributor

This just cleans up the output of unit test in compile.jl.

@tkelman tkelman added the test This change adds or pertains to unit tests label Aug 8, 2015
@tkelman
Copy link
Contributor

tkelman commented Aug 8, 2015

Yes, would like to clean this up, thanks. Though would be good to actually check and verify the error message in the caught exception, and maybe some of the redirected output.

@ScottPJones
Copy link
Contributor Author

Yes, better to verify at least some of the output (with the backtrace it will be very platform specific, too much for exact matching, I guess)
Could you merge and we can make it even better later, or do you want to wait for some checking of output?

@tkelman
Copy link
Contributor

tkelman commented Aug 8, 2015

Something about the redirection appears to have failed and timed out on appveyor.

@ScottPJones ScottPJones force-pushed the spj/redirectcompile branch 2 times, most recently from b489ff6 to be7fda0 Compare August 10, 2015 00:50
@ScottPJones
Copy link
Contributor Author

@tkelman I think this may be showing some problem with Base.compilecache, possibly with exception handling. Do you see any reason that the try/catch code in this case should not work as expected?
cc: @JeffBezanson

@tkelman
Copy link
Contributor

tkelman commented Aug 10, 2015

Looks like a bug somewhere, but I have no idea what's wrong here.

@ScottPJones ScottPJones changed the title Eliminate backtrace display when testing __precompile__() WIP: Eliminate backtrace display when testing __precompile__() Aug 15, 2015
@tkelman tkelman mentioned this pull request Aug 21, 2015
Merged
@tkelman tkelman mentioned this pull request Sep 5, 2015
Closed
@tkelman tkelman mentioned this pull request Sep 22, 2015
Merged
@ScottPJones
Eliminate backtrace display when testing __precompile__()
88847c6 
Prevent warning messages to STDERR

Move compile test earlier

Debug problems with background processes

Rebase to latest master

Further updates
@vtjnash vtjnash mentioned this pull request Nov 24, 2015
Merged
@tkelman
Copy link
Contributor

tkelman commented Nov 24, 2015

closing in favor of #14117

@tkelman tkelman closed this Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScottPJones @tkelman