-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make @deprecate_binding
work with --depwarn
cmdline flags
#13269
Conversation
Nice, thanks. |
awesome. note to self to also backport 184c56b with this |
Does Appveyor just time out after 40 minutes? |
redirection hang, maybe same as #12519 |
Since we should try to get this backported for RC3, unless someone has a great idea for how to fix the redirection bug on Windows I propose making the tests unix-only for now with a FIXME comment. |
Ping. This is needed for RC3. Do you have time to implement my suggestion, or need someone else to do it? |
ae5452a
to
31a0c55
Compare
done On Wed, Sep 23, 2015 at 6:49 PM, Tony Kelman notifications@github.com
|
You didn't add a FIXME comment and a reference to the issue/PR number, which is an important thing to put in for hacks like these otherwise we'll never remember why things are running conditionally - I had done ae5452a but your version at least runs some of the tests. |
go ahead |
Will this also make deprecation's only print once for each deprecation like for functions? Right now, it feels that whatever command I run from an external package i get 10 pages of deprecation warnings. |
Bump. Ready to merge? |
Make `@deprecate_binding` work with `--depwarn` cmdline flags
Adds tests for
--depwarn
and@deprecate_binding
.cc @tkelman