Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @deprecate_binding work with --depwarn cmdline flags #13269

Merged
merged 2 commits into from
Sep 24, 2015

Conversation

jakebolewski
Copy link
Member

Adds tests for --depwarn and @deprecate_binding.

cc @tkelman

@JeffBezanson
Copy link
Sponsor Member

Nice, thanks.

@tkelman
Copy link
Contributor

tkelman commented Sep 22, 2015

awesome. note to self to also backport 184c56b with this

@jakebolewski
Copy link
Member Author

Does Appveyor just time out after 40 minutes?

@tkelman
Copy link
Contributor

tkelman commented Sep 22, 2015

redirection hang, maybe same as #12519

@tkelman
Copy link
Contributor

tkelman commented Sep 23, 2015

Since we should try to get this backported for RC3, unless someone has a great idea for how to fix the redirection bug on Windows I propose making the tests unix-only for now with a FIXME comment.

@tkelman
Copy link
Contributor

tkelman commented Sep 23, 2015

Ping. This is needed for RC3. Do you have time to implement my suggestion, or need someone else to do it?

@jakebolewski
Copy link
Member Author

done

On Wed, Sep 23, 2015 at 6:49 PM, Tony Kelman notifications@github.com
wrote:

Ping. This is needed for RC3. Do you have time to implement my suggestion,
or need someone else to do it?


Reply to this email directly or view it on GitHub
#13269 (comment).

@tkelman
Copy link
Contributor

tkelman commented Sep 24, 2015

You didn't add a FIXME comment and a reference to the issue/PR number, which is an important thing to put in for hacks like these otherwise we'll never remember why things are running conditionally - I had done ae5452a but your version at least runs some of the tests.

@jakebolewski
Copy link
Member Author

go ahead

jakebolewski added a commit that referenced this pull request Sep 24, 2015
@KristofferC
Copy link
Sponsor Member

Will this also make deprecation's only print once for each deprecation like for functions? Right now, it feels that whatever command I run from an external package i get 10 pages of deprecation warnings.

@JeffBezanson
Copy link
Sponsor Member

Bump. Ready to merge?

jakebolewski added a commit that referenced this pull request Sep 24, 2015
Make `@deprecate_binding` work with `--depwarn` cmdline flags
@jakebolewski jakebolewski merged commit 4d7352d into master Sep 24, 2015
@jakebolewski jakebolewski deleted the jcb/depwarnbindings branch September 24, 2015 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants