[master] bump version of embedded git for windows

[felipenoris]

This will optimize overall performance of Pkg module on windows.
Also, somehow I´m unable to skip firewall using https insteadOf git workaround on current git version that ships with julia for windows. With this update, everything works fine and now I´m able to use julia at work.

I would recommend some more testing on this before merging. I was unable to run make binary-dist, but make win-extras worked fine, and 7z x PortableGit.7z also worked.

I also tested the current Julia rc with the new Git folder, and it runs smoothly. I did this on win7 and win10, both 64bit.

I also noticed the unpacked Git folder is smaller (old was 260MB, new is 190MB).

[felipenoris]

appveyor looks bad

[hayd]

master uses libgit2 rather than bundled git, this would make sense as a PR to release-0.4 branch.

[felipenoris]

Alright. I´ll do that. Thanks!

[felipenoris]

@hayd so I guess we should remove those lines on master. Is that the case?

[hayd]

Sorry! Maybe git was added back in as a fall-back for some unsupported methods in Pkg. I'm not sure actually. cc @wildart @tkelman

[tkelman]

We still bundle it on master but it's mostly unused there and I plan to take it out before 0.5 gets released. I actually wouldn't mind merging this to master first just for testing's sake

[felipenoris]

@tkelman I redirected this PR to release-0.4 [https://github.com//pull/13501]. I also find it useful to merge here since it can´t be removed right now. I´ll just reopen this PR to master ok?

[tkelman]

I think it could be removed from master, but it's also less risky to test on nightlies than the release branch.

[hayd]

I´ll just reopen this PR to master ok?

Github may be upset you deleted and reopened, so just open another. Sorry about the confusion.

[tkelman]

As long as you haven't force pushed to the branch after closing it should allow you to restore the branch and reopen.

[felipenoris]

It turns out appveyor got a lot happier when testing on release-0.4 branch... Maybe we should just merge to the release branch on #13501 and work on removing git from master branch.

[felipenoris]

@hayd, don´t worry. It was useful to test appveyor on both branches.
@tkelman, this PR and #13501 are both opened. Please, feel free to merge / cancel either one. Since you´re the one that will do the cherry-picking, you should be the one to make the call.
I also noticed Makefile is a bit different comparing master and release-0.4 branches.

[tkelman]

@twadleigh had done some testing in this direction a few weeks or months ago but I don't recall what the verdict was. I don't want to merge #13501 to the release branch until we can test it thoroughly, but it's fine to leave both open for now.

[twadleigh]

My testing was super light, git-wise, I was mostly interested in seeing if the mintty that comes along with the new git would host julia nicely.

[tkelman]

which we could do as a side benefit on release-0.4, but your other PR would still be needed on master after removing cmd line git

[felipenoris]

@tkelman , although the tests passed, appveyor didn´t look very happy, but I don´t know if that´s normal or unrelated to this merge. Is this ok?

INFO: Committing PackageWithFailingTests generated files
INFO: Testing PackageWithFailingTests
    From worker 3:       * pkg                  Test Failed
    From worker 3:    Expression: false
    From worker 3:     Evaluated: false
ERROR: LoadError: There was an error during testing
 [inlined code] from error.jl:21
 in record at test.jl:274
while loading C:\Users\appveyor\AppData\Local\Temp\1\

Btw, appveyor looked fine on that PR to release branch.

[tkelman]

if you scroll up, it was probably the same error as #13436