Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.4] bump version of embedded git for windows #13501

Merged
merged 1 commit into from
Oct 9, 2015
Merged

[release-0.4] bump version of embedded git for windows #13501

merged 1 commit into from
Oct 9, 2015

Conversation

felipenoris
Copy link
Contributor

This will optimize overall performance of Pkg module on windows.
Also, for some reason I´m unable to skip firewall using https insteadOf git workaround on current git version that ships with julia for windows. With this update, everything works fine and now I´m able to use julia at work.

I would recommend some more testing on this before merging. I was unable to run make binary-dist, but make win-extras worked fine, and 7z x PortableGit.7z also worked.

I also tested the current Julia rc with the new Git folder, and it runs smoothly. I did this on win7 and win10, both 64bit.

I also noticed the unpacked Git folder is smaller (old was 260MB, new is 190MB).

@felipenoris
Copy link
Contributor Author

See #13494 on why this PR is on release-0.4 branch and not master.

@tkelman
Copy link
Contributor

tkelman commented Oct 9, 2015

I was unable to run make binary-dist

What error were you getting?

@tkelman tkelman added the system:windows Affects only Windows label Oct 9, 2015
tkelman added a commit that referenced this pull request Oct 9, 2015
[release-0.4] bump version of embedded git for windows
@tkelman tkelman merged commit d2ace40 into JuliaLang:release-0.4 Oct 9, 2015
@felipenoris
Copy link
Contributor Author

The error was between my keyboard and my chair.
I'm still figuring out how to do it. @tkelman.
The build process was unable to find libcurl on my computer. I'm still working on that.

@tkelman
Copy link
Contributor

tkelman commented Oct 9, 2015

Speaking of pebcak, I actually intended to merge the other one before this. Oops! Well we have plenty of time for testing before 0.4.1 so we can end up reverting if there's any issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system:windows Affects only Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants