Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.4, RFC] backports for 0.4.2 #14186

Merged
merged 106 commits into from
Dec 6, 2015
Merged

[release-0.4, RFC] backports for 0.4.2 #14186

merged 106 commits into from
Dec 6, 2015

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Nov 29, 2015

cc @ViralBShah still working on this, putting up my progress so far more or less ready I think, running PkgEval now

vtjnash and others added 30 commits November 29, 2015 13:29
…ks around this issue

(cherry picked from commit af81d6c)
This makes it easier to support these operations on AbstractArrays with generic eltypes

(cherry picked from commit 82f9a21)
ref #13803
remove _pure_meta for backport
also qualify Base.MulFun
…matching

in genstdlib.jl

Fix #13906

(cherry picked from commit 1def889)
ref #13907
…ove non matching methods. Add test for the new functionality, fix  #6338.

(cherry picked from commit f8196cc)
ref #11679
(cherry picked from commit 3e7a401)
ref #13921
(cherry picked from commit 7498069)
ref #13933
[av skip]

(cherry picked from commit 59c3328)
ref #13927
You'll need access to the key and passphrase, talk to me or Elliot
if the need arises

[av skip]

(cherry picked from commit c75d146)
The socket test hangs if the directory containing the tests is
not writable to the user running the tests. Create socket in a
temporary directory that is removed upon exiting the scope.

(cherry picked from commit 7149d1a)
ref #13934
(cherry picked from commit c829f84)
ref #13943
Tested on Fedora only.

(cherry picked from commit 5b12348)
ref #12307
Addresses #13914

(cherry picked from commit 73242ec)
ref #13946
Changes in convert(::BitArray, ::AbstractArray) and
dumpbitcache():
* avoid branches in for loops
* pack 8 Bools at a time
* use inbounds

(cherry picked from commit d7cd023)
might be able to come up with better options for builds of prereleases?

(cherry picked from commit 0f2f451)
ref #13953
(cherry picked from commit 3a9e994)
ref #13985
(cherry picked from commit adff4be)
(cherry picked from commit b2459a6)
(cherry picked from commit c017f24)
ref #13977
(cherry picked from commit 627e681)
ref #13978
(cherry picked from commit 7ddd164)
also pull in a new test in test/core.jl because why not, it seems to pass
@amitmurthy
Copy link
Contributor

I just restarted the Travis build to see if it shows up again.

@tkelman
Copy link
Contributor Author

tkelman commented Dec 4, 2015

Something backported on this branch introduces an intermittent failure, since eccf231 succeeded make testall 50 times in a row locally, but 74dcb33 had several failures out of the same number of runs. Needs a bisect and a revert.

@Keno
Copy link
Member

Keno commented Dec 4, 2015

Which OS?

@tkelman
Copy link
Contributor Author

tkelman commented Dec 4, 2015

Linux 64. It's a bit unreliable to bisect since it happens somewhat rarely, but my suspicion is it's most likely 8b3c67b

@JeffBezanson
Copy link
Sponsor Member

Let's also make sure this doesn't exhibit #14245.

@amitmurthy
Copy link
Contributor

Is it the same failure every time?

@tkelman
Copy link
Contributor Author

tkelman commented Dec 5, 2015

@amitmurthy
Copy link
Contributor

8b3c67b is a hygiene fix. We can try reverting that, but the issue actually seems to be a memory corruption.

@amitmurthy
Copy link
Contributor

FWIW, for i in seq 1 50; do ../julia runtests.jl parallel; done just went through on a local Linux 64 machine. Since the parallel test spawns out parallel_exec.jl, the original UndefRef error should have shown up.

Something in the Travis environment is triggering this?

@tkelman
Copy link
Contributor Author

tkelman commented Dec 5, 2015

Or possibly something caused by a different earlier test executed on the same worker?

@amitmurthy
Copy link
Contributor

That does not hold true for the parallel test.

julia/test/parallel.jl

Lines 14 to 16 in 071390a

cmd = `$(Base.julia_cmd()) $inline_flag $cov_flag --check-bounds=yes --depwarn=error parallel_exec.jl`
if !success(pipeline(cmd; stdout=STDOUT, stderr=STDERR)) && ccall(:jl_running_on_valgrind,Cint,()) == 0

parallel_exec.jl is run outside the initial set of julia processes.

@amitmurthy
Copy link
Contributor

It took a few hours, but 50 runs of runtests.jl all just finished with no errors locally.

  | | |_| | | | (_| |  |  Version 0.4.2-pre+117 (2015-12-03 21:37 UTC)
 _/ |\__'_|_|_|\__'_|  |  tk/backports-0.4.2/74dcb33* (fork: 99 commits, 9 days)
|__/                   |  x86_64-linux-gnu

julia> versioninfo()
Julia Version 0.4.2-pre+117
Commit 74dcb33* (2015-12-03 21:37 UTC)
Platform Info:
  System: Linux (x86_64-linux-gnu)
  CPU: Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
  WORD_SIZE: 64
  BLAS: libopenblas (USE64BITINT DYNAMIC_ARCH NO_AFFINITY Haswell)
  LAPACK: libopenblas64_
  LIBM: libopenlibm
  LLVM: libLLVM-3.3

@tkelman
Copy link
Contributor Author

tkelman commented Dec 5, 2015

I think it might be that my openblas patch should be windows only. Needs looking into upstream to see if the next release is going to have this same issue.

@tkelman
Copy link
Contributor Author

tkelman commented Dec 5, 2015

though until I backport #13569, travis should be using the ppa for openblas so that doesn't make much sense

eschnett and others added 6 commits December 6, 2015 02:21
Most importantly this skips backup files left by some editors, which otherwise confuse the script.

(cherry picked from commit 9829294)
ref #14250
(cherry picked from commit a4f2e2e)
when an old PR build gets restarted after some time, the travis API request
might not return enough builds to include the most recent one for the PR,
so the null result would incorrectly cause a 'superceded' fast-fail condition

(cherry picked from commit 111f5e5)
with cached source build of deps

ref #13569

(cherry picked from commit d7fc5d8)

Only cache deps on Travis for master and release branches

(cherry picked from commit 05301b9)

leave old travis cache in place for non-master builds

delete .pyc files from doc build

(cherry picked from commit 0055107)
@tkelman tkelman changed the title [release-0.4, WIP] backports for 0.4.2 [release-0.4, RFC] backports for 0.4.2 Dec 6, 2015
@tkelman
Copy link
Contributor Author

tkelman commented Dec 6, 2015

If this passes on Travis and AppVeyor, I think it's ready to merge and tag. If it doesn't, please copy and save the Travis logs to a gist before restarting any failed jobs.

@nalimilan
Copy link
Member

FWIW, the Fedora/RHEL package builds fine with the current version of this PR.

tkelman added a commit that referenced this pull request Dec 6, 2015
[release-0.4, RFC] backports for 0.4.2
@tkelman tkelman merged commit 4f951cf into release-0.4 Dec 6, 2015
@tkelman tkelman deleted the tk/backports-0.4.2 branch December 6, 2015 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.