Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #18189 (Add deprecation of @unix_only, etc. to NEWS) #18254

Merged
merged 8 commits into from
Sep 2, 2016
Merged

Fix #18189 (Add deprecation of @unix_only, etc. to NEWS) #18254

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e390936
Fix #18189 (Add deprecation of etc. to NEWS)
BrandonEdwards Aug 26, 2016
f8e7a43
Remove mentioning of @static, add as a note
BrandonEdwards Aug 27, 2016
0471fb6
Merge branch 'master' of https://github.com/JuliaLang/julia into news…
BrandonEdwards Aug 28, 2016
7f64ff9
Merge branch 'master' of https://github.com/JuliaLang/julia into news…
BrandonEdwards Aug 30, 2016
1381946
Added reference to Handling Operating System Variation section in manual
BrandonEdwards Aug 30, 2016
fabb96e
Changed reference numbers
BrandonEdwards Aug 30, 2016
abb9594
Merge branch 'master' of https://github.com/JuliaLang/julia into news…
BrandonEdwards Sep 2, 2016
f9c3f5c
Change PR number
BrandonEdwards Sep 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,16 @@ Deprecated or removed
* The no-op `transpose` fallback has been deprecated. Consider introducing suitable
`transpose` methods or calling `permutedims(x, [2,1])` ([#13171], [#17075], [#17374]).

* The following macros have been deprecated ([#18189]):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

18189 is not the right reference, it should refer to when the actual change was made

* `@windows` is deprecated in favor of `@static is_windows()`
* `@unix` is deprecated in favor of `@static is_unix()`
* `@osx` is deprecated in favor of `@static is_apple()`
* `@linux` is deprecated in favor of `@static is_linux()`
* `@windows_only` is deprecated in favor of `@static if is_windows()`
* `@unix_only` is deprecated in favor of `@static if is_unix()`
* `@osx_only` is deprecated in favor of `@static if is_apple()`
* `@linux_only` is deprecated in favor of `@static if is_linux()`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These shouldn't mention @static, Mentioning that using @static could be useful/necessary when used in a function's local scope at the end is ok.


Command-line option changes
---------------------------

Expand Down