Fix #18189 (Add deprecation of @unix_only, etc. to NEWS) #18254
Conversation
|
See also #18189 (comment) |
| * `@windows_only` is deprecated in favor of `@static if is_windows()` | ||
| * `@unix_only` is deprecated in favor of `@static if is_unix()` | ||
| * `@osx_only` is deprecated in favor of `@static if is_apple()` | ||
| * `@linux_only` is deprecated in favor of `@static if is_linux()` |
There was a problem hiding this comment.
These shouldn't mention @static, Mentioning that using @static could be useful/necessary when used in a function's local scope at the end is ok.
|
I've updated it and added a note about using |
tkelman
added
docs
| @@ -478,6 +478,17 @@ Deprecated or removed | |||
| * The no-op `transpose` fallback has been deprecated. Consider introducing suitable | |||
| `transpose` methods or calling `permutedims(x, [2,1])` ([#13171], [#17075], [#17374]). | |||
|
|
|||
| * The following macros have been deprecated ([#18189]): | |||
There was a problem hiding this comment.
18189 is not the right reference, it should refer to when the actual change was made
|
As in the #18255 PR, we should also refer to http://docs.julialang.org/en/latest/manual/handling-operating-system-variation/#man-handling-operating-system-variation here. |
| @@ -478,6 +478,17 @@ Deprecated or removed | |||
| * The no-op `transpose` fallback has been deprecated. Consider introducing suitable | |||
| `transpose` methods or calling `permutedims(x, [2,1])` ([#13171], [#17075], [#17374]). | |||
|
|
|||
| * The following macros have been deprecated ([#6674] and [#4233]): | |||
There was a problem hiding this comment.
I would use the actual PR number
There was a problem hiding this comment.
Should it be the PR number of this PR, or the one where the macros were actually deprecated? Sorry, this is my first ever PR to anything open source, still learning my way around a bit!
There was a problem hiding this comment.
the pr where the macros were deprecated. no worries, questions are encouraged.
|
Thanks @bedwards144! |
…liaLang#18254) * Fix JuliaLang#18189 (Add deprecation of etc. to NEWS) * Remove mentioning of @static, add as a note * Added reference to Handling Operating System Variation section in manual * Changed reference numbers * Change PR number
fixes #18189