Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #18189 (Add deprecation of @unix_only, etc. to NEWS) #18254

Merged
merged 8 commits into from
Sep 2, 2016
Merged

Fix #18189 (Add deprecation of @unix_only, etc. to NEWS) #18254

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e390936
Fix #18189 (Add deprecation of etc. to NEWS)
BrandonEdwards Aug 26, 2016
f8e7a43
Remove mentioning of @static, add as a note
BrandonEdwards Aug 27, 2016
0471fb6
Merge branch 'master' of https://github.com/JuliaLang/julia into news…
BrandonEdwards Aug 28, 2016
7f64ff9
Merge branch 'master' of https://github.com/JuliaLang/julia into news…
BrandonEdwards Aug 30, 2016
1381946
Added reference to Handling Operating System Variation section in manual
BrandonEdwards Aug 30, 2016
fabb96e
Changed reference numbers
BrandonEdwards Aug 30, 2016
abb9594
Merge branch 'master' of https://github.com/JuliaLang/julia into news…
BrandonEdwards Sep 2, 2016
f9c3f5c
Change PR number
BrandonEdwards Sep 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,17 @@ Deprecated or removed
* The no-op `transpose` fallback has been deprecated. Consider introducing suitable
`transpose` methods or calling `permutedims(x, [2,1])` ([#13171], [#17075], [#17374]).

* The following macros have been deprecated ([#6674] and [#4233]):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use the actual PR number

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be the PR number of this PR, or the one where the macros were actually deprecated? Sorry, this is my first ever PR to anything open source, still learning my way around a bit!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pr where the macros were deprecated. no worries, questions are encouraged.

* `@windows` is deprecated in favor of `is_windows()`
* `@unix` is deprecated in favor of `is_unix()`
* `@osx` is deprecated in favor of `is_apple()`
* `@linux` is deprecated in favor of `is_linux()`
* `@windows_only` is deprecated in favor of `if is_windows()`
* `@unix_only` is deprecated in favor of `if is_unix()`
* `@osx_only` is deprecated in favor of `if is_apple()`
* `@linux_only` is deprecated in favor of `if is_linux()`
* NOTE: Using `@static` could be useful/necessary when used in a function's local scope. See details at the section entitled [Handling Operating System Variation](http://docs.julialang.org/en/latest/manual/handling-operating-system-variation/#man-handling-operating-system-variation) in the manual.

Command-line option changes
---------------------------

Expand Down