-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REPL: enable visual selection #24725
Conversation
1256ff9
to
6f4aad0
Compare
I will merge in a couple of days if no objection. |
Sorry for out of scope comment but maybe you could do small fix in one commit: Home, ^A | Move to beginning of line |
Thanks for reporting, and actually you are very welcome to contribute this fix! (I won't do it in this PR, as it's unrelated). |
6f4aad0
to
f2d3b85
Compare
I added basic support for "shift-selection", i.e. pressing shift with an arrow key highlights the region. |
This can be useful for subsequent tasks, in particular for being able to alter the behavior of `refresh_line` depending on which command is currently running.
Like in ipython and emacs, when the mark is set twice in a row, the region is set to "active", which means visually that it is highlighted. Once it's active, setting the mark or pressing Ctrl-G de-activates the region.
Navigating with arrow-keys while pressing the shift key activates the region.
f2d3b85
to
25b82ff
Compare
There is one travis failure, which was seen elsewhere so must be not related:
|
Like in ipython and emacs, when the mark is set twice in a row,
the region is set to "active", which means visually that
it is highlighted. Once it's active, setting the mark or pressing
Ctrl-G de-activates the region.