Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in LineEdit #25255

Merged
merged 1 commit into from
Dec 23, 2017
Merged

Fix typo in LineEdit #25255

merged 1 commit into from
Dec 23, 2017

Conversation

Keno
Copy link
Member

@Keno Keno commented Dec 22, 2017

I have no idea what this code is for, but it looked wrong while passing by. I suspect whatever this does needs a test.

I have no idea what this code is for, but it looked wrong while passing by. I suspect whatever this does needs a test.
@bramtayl
Copy link
Contributor

Concerning that this wasn't caught by testing?

@ararslan ararslan added bugfix This change fixes an existing bug needs tests Unit tests are required for this change REPL Julia's REPL (Read Eval Print Loop) labels Dec 23, 2017
@ararslan
Copy link
Member

Looks like that was added in #24725, cc @rfourquet

@rfourquet
Copy link
Member

Sorry for this, but don't worry, this currently doesn't affect any functionality: this COMMAND_GROUPS dictionary is currently used only very partially. I made it that way both by anticipation of a future feature, and for internal documentation. Thanks for the fix!

@rfourquet rfourquet merged commit 2d1d6d0 into master Dec 23, 2017
@rfourquet rfourquet deleted the kf/letypo branch December 23, 2017 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug needs tests Unit tests are required for this change REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants