Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very much WIP: put Pkg3 in stdlib #25115

Closed
wants to merge 1 commit into from
Closed

Very much WIP: put Pkg3 in stdlib #25115

wants to merge 1 commit into from

Conversation

KristofferC
Copy link
Sponsor Member

This is quite still a lot of WIP but I wanted to put this up since I am going on vacation next week.

For now, the usefulness of this branch is probably limited to that people can build the branch locally and get a feel for Pkg3.

There are still stuff that needs to be merged in the Pkg3 repo and this needs to be rebased on current master. There are also some design decisions left to be made.

One things I want to know here is that it is extremely important to get the precompilation stuff right for Pkg3. It is very slow without precompilation directives, but with proper ones (that I hope I have here) it is pretty snappy.

@vchuravy
Copy link
Member

I would propose that we either do this via a git-submodule or download Pkg3 during the Julia build, instead of including all the source files (without history) in the main repository.
We need a path forward for stdlib packages that live outside of the JuliaLang repository anyway.

@KristofferC
Copy link
Sponsor Member Author

I will add the history. There was just a lack of time which is why this PR is not very nice. I put it up anyway since perhaps someone want to play with it. I don't think submodules are a good way forward. Especially not for Pkg that needs significant hooks into Base. From what I have read, a lot of people regret using submodules.

@StefanKarpinski
Copy link
Sponsor Member

Git submodules solve zero problems in my experience and create many of them.

@vchuravy
Copy link
Member

As an alternative to submodules or source code import I propose something along the line of https://github.com/JuliaLang/julia/tree/vc/pkg3

@kshyatt kshyatt added packages Package management and loading stdlib Julia's standard library labels Dec 16, 2017
@vchuravy vchuravy mentioned this pull request Dec 17, 2017
5 tasks
@DilumAluthge DilumAluthge deleted the kc/pkg3 branch March 25, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Package management and loading stdlib Julia's standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants