-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP/RFC] add Pkg3 to stdlib #25140
[WIP/RFC] add Pkg3 to stdlib #25140
Conversation
I updated the PR by porting some of the changes from #25115 and adding a TODO. Personally this attempt makes even more sense to me after I realised that |
default: get | ||
|
||
PKG3_VERSION := a554607c939ab73d89c3e7c6a3dd08fd870145e8 | ||
PKG3_URL := https://github.com/JuliaLang/Pkg3.jl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me. It's annoying to be in yet another bootstrap situation where the tooling (Pkg3 in this case) can't be used to build itself.
What would presumably be easier would be for an already built version of Pkg3 to emit a consistent set of requirements for the stdlib which could then be hard coded in this repo in a format which this makefile can consume.
Then updating this will be less manual as the stdlib grows to include more modules from various repositories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(caveat: I know next to nothing about Pkg3
!)
As soon as #25455 is merged, we can revisit this – we do need to move |
I am putting this up as an alternative to #25115 and to garner feedback on this approach even if we decide to do a full sourcetree import of Pkg3.
The idea is to treat external
stdlib
packages similar to external dependencies, this currently uses git to do the version resolution, but we should probably use tarballs + SHA, with the option to usegit
for development (similar to how we treat LLVM).I am by no means a master of
Makefile
s so feedback on the structure and design would be especially welcomed.##TODO:
Pkg3
work on current masterPkg3
should be renamed toPkg
Pkg3
work with_Pkg
stubTOML
,TerminalMenues
, andBinaryProvider
to stdlib