Fix llvm-assertion: don't instantiate 0-sized structs (ghost types) #31431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I understand it, LLVM doesn't support 0-sized structs (ghost types), which julia makes significant use of. This fixes an incorrect behavior in the julia compiler accidentally attempting to instantiate such 0-sized structs. When using a debug build of LLVM, this fails with an assertion error, but failed silently on standard LLVM.
|
Also i think this should get some tests as well. |
vtjnash
reviewed
Mar 21, 2019
|
fixes #29929 |
JeffBezanson
added
compiler:codegen
Co-Authored-By: NHDaly <NHDaly@gmail.com>
replace `mark_julia_type()` with `return e` always.
|
I applied your suggestions. I don't know what this code does so i'm acting blind. :) |
|
I've added a test case for #29929 and a few others that exercise this change. |
JeffBezanson
approved these changes
Mar 25, 2019
|
Any reason not to merge? This PR appears to have a higher percentage of green checkmarks that I no longer know the meaning of than the average PR. |
|
Should have squashed!! 😠 |
|
Mea culpa! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this commit from a patch that @JeffBezanson sent me. I'm not familiar with this code myself, so I don't know if this is sufficient, but I wanted to open this PR so that we didn't forget about this fix! :) Feel free to commit to it directly / take it over / replace it with a new PR or whatever.
In particular, we were a bit unsure about what should go in the second
elseblock, where we currently putreturn e;.As I understand it, LLVM doesn't support 0-sized structs (ghost types),
which julia makes significant use of. This fixes an incorrect behavior
in the julia compiler accidentally attempting to instantiate such
0-sized structs.
When using a debug build of LLVM, this fails with an assertion error,
but failed silently on standard LLVM.
This came up when debugging #31418.