Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix llvm-assertion: don't instantiate 0-sized structs (ghost types) #31431

Merged
merged 5 commits into from
Mar 25, 2019
Merged

Fix llvm-assertion: don't instantiate 0-sized structs (ghost types) #31431

merged 5 commits into from
Mar 25, 2019

Commits on Mar 21, 2019

  1. Fix llvm-assertion: don't load ghost types 

    As I understand it, LLVM doesn't support 0-sized structs (ghost types),
which julia makes significant use of. This fixes an incorrect behavior
in the julia compiler accidentally attempting to instantiate such
0-sized structs.

When using a debug build of LLVM, this fails with an assertion error,
but failed silently on standard LLVM.
    @NHDaly
    NHDaly committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    0d0b853 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2019

  1. Apply vtjnash's suggested change to src/intrinsics.cpp 

    Co-Authored-By: NHDaly <NHDaly@gmail.com>
    @vtjnash @NHDaly
    vtjnash and NHDaly authored Mar 22, 2019
    Configuration menu
    Copy the full SHA
    8df4de4 View commit details
    Browse the repository at this point in the history

  2. Apply vtjnash's suggestion to src/intrinsics.cpp 

    replace `mark_julia_type()` with `return e` always.
    @NHDaly
    NHDaly authored Mar 22, 2019
    Configuration menu
    Copy the full SHA
    d0b0ca3 View commit details
    Browse the repository at this point in the history

  3. Add test for Issue JuliaLang#29929: `unsafe_store!(::Ptr{Nothing}, ::… 

    …Nothing)`
    @NHDaly
    NHDaly committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    3725072 View commit details
    Browse the repository at this point in the history

  4. More tests: can load/store any 0-sized struct

    @NHDaly
    NHDaly committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    33c15d3 View commit details
    Browse the repository at this point in the history