Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Zlib BB release to v1.2.11+6 #33535

Merged
merged 1 commit into from
Oct 13, 2019
Merged

Conversation

staticfloat
Copy link
Member

@staticfloat staticfloat commented Oct 11, 2019

Fantastic chain of events:

  • Zlib BB release v1.2.11+3 had symlinks in the windows tarball
  • These unpacked just fine using Cygwin's tar on the windows buildbots
  • After building, 7z sees Cygwin's symlink file contents as a string,
    packges it up just fine
  • Julia, when installed on a windows machine, unpacks a libz.dll that
    is a garbage fake symlink file, tries to open libz.dll and throws out
    a %1 is not a valid Win32 application. error.

Example log: https://ci.appveyor.com/project/Ward9250/libz-jl/builds/28054772/job/5jqq9wpk8iaieg6m

Fantastic chain of events:

* Zlib BB release `v1.2.11+3` had symlinks in the windows tarball
* These unpacked just fine using Cygwin's `tar` on the windows buildbots
* After building, `7z` sees Cygwin's symlink file contents as a string,
packges it up just fine
* Julia, when installed on a windows machine, unpacks a `libz.dll` that
is a garbage fake symlink file, tries to open `libz.dll` and throws out
a `%1 is not a valid Win32 application.` error.

[0]: https://ci.appveyor.com/project/Ward9250/libz-jl/builds/28054772/job/5jqq9wpk8iaieg6m
@staticfloat staticfloat added building Build system, or building Julia or its dependencies backport 1.3 labels Oct 11, 2019
@staticfloat staticfloat merged commit c3e3b7a into master Oct 13, 2019
@staticfloat staticfloat deleted the sf/fix_7z_zlib_problems branch October 13, 2019 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants