Bump Zlib BB release to v1.2.11+10 which enables -O3 optimisation
#35979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any build changes in BB should also be mirrored in |
ViralBShah
added
the
building
|
Ok, thanks, I'll update tomorrow. It looks like #33535 should have already switched to using CMake 😈 |
giordano
commented
May 22, 2020
Merged
15 tasks
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
…JuliaLang#35979) * Bump Zlib BB release to `v1.2.11+10` which enables `-O3` optimisation * Configure Zlib with CMake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reference, this is the corresponding PR to Yggdrasil: JuliaPackaging/Yggdrasil#1051. Not sure whether I need to update some build commands in case one wants to build zlib from source.
See for example JuliaIO/CodecZlib.jl#53 about the poor performance of current build.
Given the important performance boost, it may be worth to backport this to older releases.