Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Pkg version to include fix to git tree hash calculation #33985

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

staticfloat
Copy link
Member

This fixes some recently-reported issues with restrictive umask's and
the Pkg.Artifacts git tree hash calculation.

X-ref: JuliaPackaging/BinaryBuilder.jl#527

@StefanKarpinski
Copy link
Member

This fix alone would be a candidate for a very quick 1.3.1 release since the umask artifact issue is rather bad.

@giordano
Copy link
Contributor

Does this include improvement of loading time of jll packages? Also that would be good to have in 1.3.1

@staticfloat
Copy link
Member Author

This fix alone would be a candidate for a very quick 1.3.1 release since the umask artifact issue is rather bad.

Note that this is to update master; to update release-1.3 we should use a separate PR that bases itself off of @fredrikekre's very helpful 1.3 backports branch.

Does this include improvement of loading time of jll packages? Also that would be good to have in 1.3.1

Yes, both this PR and Fredrik's 1.3 backporting branch contain the speedups.

@KristofferC
Copy link
Member

KristofferC commented Dec 1, 2019

For precompilation time of jll packages we also need to use some of the artifact functionality in the precompile script. I agree we should get a 1.3.1 out fairly quickly.

@KristofferC
Copy link
Member

Should include JuliaLang/Pkg.jl#1517 here as well, since right now, master is pretty broken for packages overall.

@staticfloat
Copy link
Member Author

For precompilation time of jll packages we also need to use some of the artifact functionality in the precompile script.

We could do something like download a JLL package into the Julia source directory (before the build) and install the artifacts somewhere, then using it within the precompile script to precompile the loading code (but not the downloading code). Is that what you have in mind?

@KristofferC
Copy link
Member

We could do something like download a JLL package into the Julia source directory (before the build) and install the artifacts somewhere, then using it within the precompile script to precompile the loading code (but not the downloading code). Is that what you have in mind?

Yeah, just bundle something with Pkg that allows us to use the artifact macro in the precompile script.

This fixes some recently-reported issues with restrictive `umask`'s and
the `Pkg.Artifacts` git tree hash calculation.

X-ref: JuliaPackaging/BinaryBuilder.jl#527
@staticfloat
Copy link
Member Author

JuliaLang/Pkg.jl#1521

@fredrikekre fredrikekre merged commit d945adf into master Dec 2, 2019
@fredrikekre fredrikekre deleted the sf/pkg_bump_umasks branch December 2, 2019 21:46
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
This fixes some recently-reported issues with restrictive `umask`'s and
the `Pkg.Artifacts` git tree hash calculation.

X-ref: JuliaPackaging/BinaryBuilder.jl#527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants