Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Backports release 1.4.2 #35825

Merged
merged 12 commits into from
May 14, 2020
Merged

WIP: Backports release 1.4.2 #35825

merged 12 commits into from
May 14, 2020

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented May 10, 2020 •
edited
Loading

Backported PRs:

Need manual backport:

Non-merged PRs with backport label:

staticfloat and others added 12 commits May 10, 2020 11:53
@staticfloat @KristofferC
Fix MacOS Notarization (#35080)
889de01 
We need to individually sign each Mach-O file independently, otherwise
notarization bails.  Note that you must sign the overall `.app` after
each individual file is signed.

I've also added more Entitlements.

I've gone for a "gentle shotgun" approach, turning on everything that I think
we could reasonably want.  I wait expectantly for someone to complain that
they need Location access turned on for some package.  ;)

(cherry picked from commit 418f111)
@vtjnash @KristofferC
precompile: avoid a potential crash when adding methods (#35378)
d04036f 
fixes #29859

(cherry picked from commit 8a55a27)
@ssikdar1 @KristofferC
add some checks for invalid expressions (#35363)
fe43406 
add null check for module-default-defs, fix #34544

fix #35367 as well

change jl_eval_module_expr to check 3rd arg is block

(cherry picked from commit 8057c60)
@vchuravy @KristofferC
implement LibuvStream interface for BufferStream (#35545)
3be9f10 
It is noted as a non-OS stream, but has also been a subtype
of LibuvStream since forever. #32309 did not add the `readerror`
field.

(cherry picked from commit de04210)
@ararslan @KristofferC
Add a fast path for returning "" from repeat(str, 0) (#35579)
75c7c60 
Currently the case where `r == 0` falls through the same logic as every
other non-negative value of `r` (aside from 1). This works for signed
integers. However, this does not work for unsigned integers: in the loop
where we unsafely fill in the output string, we're looping from 0 to `r
- 1`, which for unsigned integers wraps around and causes us to request
the address of the output string at a location that is well beyond what
was allocated.

Fixes #35578.

(cherry picked from commit 1dcb42f)
@JeffBezanson @KristofferC
exclude types with free variables from type_morespecific (#35555)
9651235 
(cherry picked from commit 0cedde6)
@rfourquet @KristofferC
fix buggy rand(RandomDevice(), Bool) (#35590)
e76bf14 
(cherry picked from commit 0bab06f)
@Keno @KristofferC
Fix dropped bytes when bulk reading from uv streams with oversized bu…
0203e94 
…ffers (#35695)

In readbytes!(s::UVStream, buf::AbstractVector{UInt8}, nb), we wrap `buf`
in a PipeBuffer of maxsize nb and swap it in as the main buffer for the
stream `s`. However, when we inform libuv of the size of the buffer,
we instead use the size of the underlying array, which can be larger.
In that case, we probably either drop bytes or override something that
the user did not want overriden.

(cherry picked from commit 3a84b51)
@maleadt @KristofferC
Fix and test PCRE error message getter. (#35728)
36d2600 
(cherry picked from commit 9c2492e)
@ssikdar1 @KristofferC
Have matrix square root account for Rii=Rjj=0 to prevent NaN values (#…
8b3a4a2 
…35758)

(cherry picked from commit 880c731)
@JeffBezanson @KristofferC
fix #35134, regression in printing nested quote Exprs (#35479)
c9b9b8c 
(cherry picked from commit e00db7b)
@KristofferC
bump Pkg version to latest release.1.4
c0b1a0c
@KristofferC KristofferC reopened this May 10, 2020
@KristofferC
Copy link
Member Author

@nanosoldier runbenchmarks(ALL, vs =":release-1.4")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@KristofferC
Copy link
Member Author

@nanosoldier runtests(ALL, vs = ":release-1.4")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

@KristofferC
Copy link
Member Author

@nanosoldier runtests(["ARCHModels", "Autologistic", "BlobTracking", "BoltzmannMachines", "BufferedStreams", "DiffEqBayes", "DiskDataProviders", "Graph500", "KrylovKit", "MriResearchTools", "NeuralArithmetic", "TensorNetworkAD"], vs = ":release-1.4")

@maleadt
Copy link
Member

maleadt commented May 13, 2020

Doing some PkgEval development, sorry for the noise.

@nanosoldier runtests(["ARCHModels", "Autologistic", "BlobTracking", "BoltzmannMachines", "BufferedStreams", "DiffEqBayes", "DiskDataProviders", "Graph500", "KrylovKit", "MriResearchTools", "NeuralArithmetic", "TensorNetworkAD"], vs = ":release-1.4")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

@KristofferC KristofferC merged commit f16c4b0 into release-1.4 May 14, 2020
@ararslan ararslan deleted the backports-release-1.4 branch May 14, 2020 18:24
@haampie haampie mentioned this pull request Jun 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.