REPL prefix search: add ^x "pass through" key #36173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfourquet
added
bugfix
|
Who would be good to review this? |
Maybe @vtjnash who IIRC made the change that makes Julia exit instead of getting a runtime "REPL keymap" error? |
|
These kind of subtle behavior changes need a REPL test, otherwise, they're basically guaranteed to regress. |
|
I'm quite guilty as I knew tests were missing, it's just frustrating with REPL fixes to make the fix in 5 min and spend an order of magnitude more time trying to sort out how to test these things :-/ |
9 tasks
|
I will merge in a couple of days if no objection. |
KristofferC
pushed a commit
that referenced
this pull request
Jul 8, 2020
(cherry picked from commit 0960c9a)
13 tasks
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix the following bug:
Then the Julia session is exited ("^x" is a prefix keyboard shortcut, e.g. "^x^x" does "exchange-mark-and-cursor").
This PR is a very similar to #33805.
This is not a complete solution: if you have a 3-key combo as a keyboard shortcut, e.g. "^x^lb", then the session will again terminate. Then we could add
"^x**" => "*",as a "pass-through", butSo let's assume 3+-key combos are not used very much.
I'm really looking forward to fixing this "pass through" problem in a general way...