Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REPL: prefix search: more "pass through" keys #33805

Merged
merged 1 commit into from
Nov 17, 2019
Merged

REPL: prefix search: more "pass through" keys #33805

merged 1 commit into from
Nov 17, 2019

Conversation

rfourquet
Copy link
Member

This fix the following bug:

  1. press "Ctrl-P" to go to previous history entry, through "prefix history search"
  2. press "Meta-RigthArrow"

Then a spurious "C" character is inserted, because "prefix history search" doesn't pass "Meta-RightArrow" to its parent mode. Similarly for "Shift-SomeArrowKey".

@rfourquet rfourquet added REPL Julia's REPL (Read Eval Print Loop) bugfix This change fixes an existing bug labels Nov 10, 2019
@rfourquet rfourquet force-pushed the rf/repl/prefix-search-more-passthru branch from 71bbbef to ca3e779 Compare November 10, 2019 17:34
@rfourquet rfourquet mentioned this pull request Nov 11, 2019
Closed
@rfourquet rfourquet force-pushed the rf/repl/prefix-search-more-passthru branch 3 times, most recently from 7b38472 to f08916c Compare November 16, 2019 10:29
@rfourquet rfourquet force-pushed the rf/repl/prefix-search-more-passthru branch from f08916c to f778aef Compare November 17, 2019 10:15
@rfourquet rfourquet merged commit 74f2de1 into master Nov 17, 2019
@rfourquet rfourquet deleted the rf/repl/prefix-search-more-passthru branch November 17, 2019 12:55
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
@rfourquet @KristofferC
REPL: prefix search: more "pass through" keys (#33805)
4154228
@rfourquet rfourquet mentioned this pull request Jun 6, 2020
Merged
vtjnash added a commit that referenced this pull request Apr 13, 2022
@vtjnash
[REPL] remove erroneous space in test
05afef4 
Introduced by #33805 (74f2de1).
@vtjnash vtjnash mentioned this pull request Apr 13, 2022
Merged
aviatesk pushed a commit that referenced this pull request Apr 14, 2022
@vtjnash
[REPL] Fix a REPL test failure by removing an erroneous space in test (…
fbec395 
…#44972)

* [REPL] remove erroneous space in test
  Introduced by #33805 (74f2de1).
* Revert "Temporarily move the `REPL` test suite to node 1, to buy us time until we fix the underlying bugs (#44961)"
  This reverts commit 322fd70.
KristofferC pushed a commit that referenced this pull request Apr 19, 2022
@vtjnash @KristofferC
[REPL] Fix a REPL test failure by removing an erroneous space in test (…
8e2b69d 
…#44972)

* [REPL] remove erroneous space in test
  Introduced by #33805 (74f2de1).
* Revert "Temporarily move the `REPL` test suite to node 1, to buy us time until we fix the underlying bugs (#44961)"
  This reverts commit 322fd70.

(cherry picked from commit fbec395)
KristofferC pushed a commit that referenced this pull request Apr 19, 2022
@vtjnash @KristofferC
[REPL] Fix a REPL test failure by removing an erroneous space in test (…
81c8819 
…#44972)

* [REPL] remove erroneous space in test
  Introduced by #33805 (74f2de1).
* Revert "Temporarily move the `REPL` test suite to node 1, to buy us time until we fix the underlying bugs (#44961)"
  This reverts commit 322fd70.

(cherry picked from commit fbec395)
KristofferC pushed a commit that referenced this pull request May 16, 2022
@vtjnash
[REPL] Fix a REPL test failure by removing an erroneous space in test (…
159ce70 
…#44972)

* [REPL] remove erroneous space in test
  Introduced by #33805 (74f2de1).
* Revert "Temporarily move the `REPL` test suite to node 1, to buy us time until we fix the underlying bugs (#44961)"
  This reverts commit 322fd70.

(cherry picked from commit fbec395)
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@vtjnash
[REPL] Fix a REPL test failure by removing an erroneous space in test (…
5ef0035 
…#44972)

* [REPL] remove erroneous space in test
  Introduced by #33805 (74f2de1).
* Revert "Temporarily move the `REPL` test suite to node 1, to buy us time until we fix the underlying bugs (#44961)"
  This reverts commit 322fd70.

(cherry picked from commit fbec395)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@vtjnash @staticfloat
[REPL] Fix a REPL test failure by removing an erroneous space in test (…
b6216bd 
…#44972)

* [REPL] remove erroneous space in test
  Introduced by #33805 (74f2de1).
* Revert "Temporarily move the `REPL` test suite to node 1, to buy us time until we fix the underlying bugs (#44961)"
  This reverts commit 322fd70.

(cherry picked from commit fbec395)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix This change fixes an existing bug REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rfourquet