Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REPL] Fix a REPL test failure by removing an erroneous space in test (introduced by #33805) #44972

Merged
merged 2 commits into from
Apr 14, 2022
Merged

[REPL] Fix a REPL test failure by removing an erroneous space in test (introduced by #33805) #44972

merged 2 commits into from
Apr 14, 2022

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Apr 13, 2022

Fixes the REPL test failure introduced by #33805 a couple years ago

@StefanKarpinski
Copy link
Member

What's with the PR title?

@giordano
Copy link
Contributor

What's with the PR title?

When you open a pull request with multiple commits, the default title is the branch name, not the first commit of the branch

@DilumAluthge DilumAluthge changed the title Jn/44881 44963 44961 33805 [REPL] Fix a REPL test failure by removing an erroneous space in test (introduced by #33805) Apr 14, 2022
@DilumAluthge DilumAluthge added test This change adds or pertains to unit tests REPL Julia's REPL (Read Eval Print Loop) ci Continuous integration labels Apr 14, 2022
@vtjnash vtjnash added merge me PR is reviewed. Merge when all tests are passing backport 1.6 Change should be backported to release-1.6 backport 1.7 backport 1.8 Change should be backported to release-1.8 labels Apr 14, 2022
DilumAluthge
DilumAluthge approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@DilumAluthge DilumAluthge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The REPL tests are now passing on macOS x86_64, even though they are not being run on node 1.

@aviatesk aviatesk merged commit fbec395 into master Apr 14, 2022
@aviatesk aviatesk deleted the jn/44881-44963-44961-33805 branch April 14, 2022 08:19
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Apr 14, 2022
KristofferC pushed a commit that referenced this pull request Apr 19, 2022
@vtjnash @KristofferC
[REPL] Fix a REPL test failure by removing an erroneous space in test (…
8e2b69d 
…#44972)

* [REPL] remove erroneous space in test
  Introduced by #33805 (74f2de1).
* Revert "Temporarily move the `REPL` test suite to node 1, to buy us time until we fix the underlying bugs (#44961)"
  This reverts commit 322fd70.

(cherry picked from commit fbec395)
@KristofferC KristofferC mentioned this pull request Apr 19, 2022
Merged
40 tasks
KristofferC pushed a commit that referenced this pull request Apr 19, 2022
@vtjnash @KristofferC
[REPL] Fix a REPL test failure by removing an erroneous space in test (…
81c8819 
…#44972)

* [REPL] remove erroneous space in test
  Introduced by #33805 (74f2de1).
* Revert "Temporarily move the `REPL` test suite to node 1, to buy us time until we fix the underlying bugs (#44961)"
  This reverts commit 322fd70.

(cherry picked from commit fbec395)
@KristofferC KristofferC mentioned this pull request Apr 19, 2022
Merged
67 tasks
KristofferC pushed a commit that referenced this pull request May 16, 2022
@vtjnash
[REPL] Fix a REPL test failure by removing an erroneous space in test (…
159ce70 
…#44972)

* [REPL] remove erroneous space in test
  Introduced by #33805 (74f2de1).
* Revert "Temporarily move the `REPL` test suite to node 1, to buy us time until we fix the underlying bugs (#44961)"
  This reverts commit 322fd70.

(cherry picked from commit fbec395)
@KristofferC KristofferC mentioned this pull request May 16, 2022
Merged
45 tasks
@KristofferC KristofferC removed backport 1.8 Change should be backported to release-1.8 backport 1.7 labels May 26, 2022
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jul 6, 2022
This was referenced Sep 28, 2022
Closed
Closed
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@vtjnash
[REPL] Fix a REPL test failure by removing an erroneous space in test (…
5ef0035 
…#44972)

* [REPL] remove erroneous space in test
  Introduced by #33805 (74f2de1).
* Revert "Temporarily move the `REPL` test suite to node 1, to buy us time until we fix the underlying bugs (#44961)"
  This reverts commit 322fd70.

(cherry picked from commit fbec395)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@vtjnash @staticfloat
[REPL] Fix a REPL test failure by removing an erroneous space in test (…
b6216bd 
…#44972)

* [REPL] remove erroneous space in test
  Introduced by #33805 (74f2de1).
* Revert "Temporarily move the `REPL` test suite to node 1, to buy us time until we fix the underlying bugs (#44961)"
  This reverts commit 322fd70.

(cherry picked from commit fbec395)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DilumAluthge DilumAluthge DilumAluthge approved these changes

Assignees
No one assigned
Labels
ci Continuous integration REPL Julia's REPL (Read Eval Print Loop) test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vtjnash @StefanKarpinski @giordano @DilumAluthge @KristofferC @aviatesk