Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a version of code_typed that accepts a function type #36389

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

JeffBezanson
Copy link
Member

...instead of an instance. I need this all the time; is there another convenient way to do it that I missed?

@Keno
Copy link
Member

Keno commented Jun 23, 2020

No, this is good to have. I think there's like 15 different versions of this in external packages.

@timholy
Copy link
Member

timholy commented Jun 23, 2020

We probably also want a variant of which that takes a tuple-type signature.

@yuyichao
Copy link
Contributor

yuyichao commented Jun 23, 2020

Does it still have to be a separate argument in this case? (Shouldn’t it just/also accept a tuple type or tuple of types)

@Keno
Copy link
Member

Keno commented Jun 23, 2020

Maybe we should also have a version that just takes the whole signature tuple.

@JeffBezanson
Copy link
Member Author

Ok, will add.

@JeffBezanson JeffBezanson merged commit 3604a25 into master Jun 24, 2020
@JeffBezanson JeffBezanson deleted the jb/codetypedftype branch June 24, 2020 20:56
mbauman added a commit to dlfivefifty/julia that referenced this pull request Jun 26, 2020
* origin/master: (232 commits)
  Add passthrough for non-Markdown docs (JuliaLang#36091)
  Fix pointer to no longer assume contiguity (JuliaLang#36405)
  Ensure string-hashing is defined before it gets used (JuliaLang#36411)
  Make compilecache atomic (JuliaLang#36416)
  add a test for JuliaLang#30739 (JuliaLang#36395)
  Fix broken links in docstring of `repeat` (JuliaLang#36376)
  fix and de-dup cached calls to `methods_by_ftype` in compiler (JuliaLang#36404)
  ml-matches: skip unnecessary work, when possible (JuliaLang#36413)
  gf: fix some issues with the move from using a tree to a hash lookup of leaf types (JuliaLang#36413)
  Add news and manual entry for sincospi (JuliaLang#36403)
  Check axes in Array(::AbstractArray) (fixes JuliaLang#36220) (JuliaLang#36397)
  add versions of `code_typed` and `which` that accept tuple types (JuliaLang#36389)
  Fix spelling of readdir. (JuliaLang#36409)
  add sincospi (JuliaLang#35816)
  fix showing methods with unicode gensymed variable names (JuliaLang#36396)
  Add doctest: eachslice (JuliaLang#36386)
  fix documentation typo ("Ingeger")
  Refactor `abstract_eval` to separate out statements and values (JuliaLang#36350)
  fix return type of `get!` on `IdDict` (JuliaLang#36383)
  Allow single option with REPL.TerminalMenus (JuliaLang#36369)
  ...
simeonschaub pushed a commit to simeonschaub/julia that referenced this pull request Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants