fixes for "leaf-types cache for ml-matches" #36413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of leaf types
Addresses an off-by-one in the type lookup, ensures we look at at all
entries when doing invalidation, and allows putting any Type{T} object
also in the cache (I forgot these always had `simplesig`, so we needed
to handle that case too to receive the benefit for them).
If the environment is trivial (empty) and the type is a dispatch tuple, we know the intersection result is trivial, and can skip it.
|
This doesn't seem to fix #36391 --- do we know what's going on there? |
Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
|
Yeah, it's just gotten confused by the bigger caches. We'll have to fix the heuristics there later. |
vtjnash
added a commit
that referenced
this pull request
Jun 25, 2020
…of leaf types (#36413) Addresses an off-by-one in the type lookup, ensures we look at at all entries when doing invalidation, and allows putting any Type{T} object also in the cache (I forgot these always had `simplesig`, so we needed to handle that case too to receive the benefit for them).
vtjnash
added a commit
that referenced
this pull request
Jun 25, 2020
If the environment is trivial (empty) and the type is a dispatch tuple, we know the intersection result is trivial, and can skip it.
mbauman
added a commit
to dlfivefifty/julia
that referenced
this pull request
Jun 26, 2020
* origin/master: (232 commits) Add passthrough for non-Markdown docs (JuliaLang#36091) Fix pointer to no longer assume contiguity (JuliaLang#36405) Ensure string-hashing is defined before it gets used (JuliaLang#36411) Make compilecache atomic (JuliaLang#36416) add a test for JuliaLang#30739 (JuliaLang#36395) Fix broken links in docstring of `repeat` (JuliaLang#36376) fix and de-dup cached calls to `methods_by_ftype` in compiler (JuliaLang#36404) ml-matches: skip unnecessary work, when possible (JuliaLang#36413) gf: fix some issues with the move from using a tree to a hash lookup of leaf types (JuliaLang#36413) Add news and manual entry for sincospi (JuliaLang#36403) Check axes in Array(::AbstractArray) (fixes JuliaLang#36220) (JuliaLang#36397) add versions of `code_typed` and `which` that accept tuple types (JuliaLang#36389) Fix spelling of readdir. (JuliaLang#36409) add sincospi (JuliaLang#35816) fix showing methods with unicode gensymed variable names (JuliaLang#36396) Add doctest: eachslice (JuliaLang#36386) fix documentation typo ("Ingeger") Refactor `abstract_eval` to separate out statements and values (JuliaLang#36350) fix return type of `get!` on `IdDict` (JuliaLang#36383) Allow single option with REPL.TerminalMenus (JuliaLang#36369) ...
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
…of leaf types (JuliaLang#36413) Addresses an off-by-one in the type lookup, ensures we look at at all entries when doing invalidation, and allows putting any Type{T} object also in the cache (I forgot these always had `simplesig`, so we needed to handle that case too to receive the benefit for them).
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
If the environment is trivial (empty) and the type is a dispatch tuple, we know the intersection result is trivial, and can skip it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to #36166 based upon review and experimental findings.