dump: ensure Array eltype layout is initialized early #37594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deserializing an array needs to examine the element type (tparam0) layout. Usually we know the layout of a DataType is initialized early (when present). This also ensures that the path to it is initialized (for our case where it may be inline allocated with interior pointers).
|
I am looking forward for this fix in 1.5.3 as this segfault bug had been blocking the next release of AlphaZero.jl. 👍 |
|
Doesn't backport cleanly. Can push a backported commit to #38122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deserializing an array needs to examine the element type (tparam0) layout. Usually we know the layout of a DataType is initialized early (when present). This also ensures that the path to it is initialized (for our case where it may be inline allocated with interior pointers).
Reported 4c805d2#comments by @KristofferC