Backports 1.5.4 #39351

vchuravy · 2021-01-21T15:48:08Z

Backported PRs:

TODO:

FreeBSD build failure
Turn https://github.com/JuliaCI/julia-buildbot/blob/master/commands/rr_capture.jl into a Noop
[ ]

…(v)` (#38399) This fixes a segfault introduced in #38049. (cherry picked from commit b602577)

* update to utf8proc 2.6 * another test (cherry picked from commit 6fbee29)

(cherry picked from commit 2362037)

@test

* added automatic keyword assignment support to @test macro * added some tests for test macro using atol keyword * x = a.x syntax support added * Update stdlib/Test/src/Test.jl Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com> Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com> (cherry picked from commit 6c42190)

Fix #38548 (cherry picked from commit 29f2f89)

Report the top of the exception stack when there's no handler. ------- Backport #38679 into release-1.5

NHDaly · 2021-01-21T19:56:52Z

Note: Backport of #37896 depends on first backporting #37557.

Thankfully #37896 should be very simple and apply almost cleanly after first doing #37557.

giordano · 2021-01-21T20:00:02Z

#38753 is already on this branch, isn't it?

Sacha0 · 2021-01-21T21:16:17Z

#38753 is already on this branch, isn't it?

Yes, it's (i.e. #38487, manually backported in #38753) already on release-1.5. Backporter probably attempted to sweep it in due to the backport-1.5 label on #38753. (I just removed the label and will update the OP.)

Sacha0 · 2021-01-21T21:20:34Z

Similarly #37613 made it into 1.5.3, so I've dropped it from the OP and removed the backport-1.5 label from #37613.

Sacha0 · 2021-01-21T22:27:13Z

A backport of #37594 made it into 1.5.3; updating the OP accordingly and removing the backport-1.5 label from that PR :).

Sacha0 · 2021-01-21T22:35:32Z

Added a commit for #37645 and dropped the backport-1.5 tag.

Sacha0 · 2021-01-21T22:38:44Z

Added a commit for #38402 and dropped the backport-1.5 tag.

Sacha0 · 2021-01-21T22:47:50Z

Cleaned up a few more items in the OP that made it into 1.5.3. Not too many commits left :).

NHDaly · 2021-01-21T23:18:24Z

base/compiler/tfuncs.jl

        return Bottom
    end
-    if s0 == Type{Module} || s0 == Type{Union{}} || isa(s0, Conditional)
+    if (s0 isa Type && s0 == Type{Union{}}) || isa(s0, Conditional)


@Sacha0 - i also did this backport, here (oops, we collided. I'm happy to drop that now that you've done it 😊):
backports-release-1.5...NHDaly:nhd-backports-release-1.5-manual

And i wasn't sure whether to pull over the isa Type change as well. Technically that was added in dcc0696, as part of (#36596), so i wasn't sure whether to backport it as well. Supposedly it's just a code cleanup, but i'm not sure if it holds in isolation from the rest of the commit.

I think the closest transformation keeping in spirit of the change we're backporting from (#37645) would be just to drop the Module part, since that's all they did in the original PR? Like this, perhaps?:

Suggested change

if (s0 isa Type && s0 == Type{Union{}}) || isa(s0, Conditional)

if s0 == Type{Union{}} || isa(s0, Conditional)

PROBABLY fine either way, but since i see you made a different decision than I made when attempting the manual bisect, I wanted to just bring this up! :)

To see the diff standalone, it's the change i made:
cc09911#diff-94ffb7fc1a419bb8439ae0ecbb4a3b5460d193e53c96bb97b50e283fdbc16a85L932-R932

I wondered the same, but err'd to adding the isa Type guard as == Type{Union{}} cannot be true unless the guard is true, and if the latter is true then the former must be true as well, so this transformation should be functionally identical modulo some additional safety with the guard (against == Type{Union{}} throwing something for non-Type s0s)? Either way is fine by me though :).

The fields are not accessible, so it is awkward to report they exist. Fixes #37630 Caused issues starting with #34804

) An undef field should always be treated equal to another undef field of the same type since there's no other way for the user to tell the difference between these. These could previously cause inconsistent comparison results or crashes. * Mark these types as `haspadding` so that they'll not hit the `memcmp` fast path. * Make sure `jl_egal` and `jl_object_id_` doesn't read bits fields in undef inline immutable field * Use `emit_getfield_knownidx` in `emit_bits_compare` so that the check can be done more easily Handle union fields of the same type in `emit_f_isa` to avoid regression. * Allow input to `emit_f_isa` to be NULL and lazily emit NULL check if necessary (cherry picked from commit e84fec4)

(cherry picked from commit 57e2ac9)

(cherry picked from commit 0a04f41)

While this takes a non-trivial amount of space in the system image (about the same as putting the Method object here, but less than putting the full edge to the MethodInstance), it is necessary to avoid the regression #36462 caused by 2e37784. (cherry picked from commit 42a1d34)

Closes #36825 (cherry picked from commit 8aaf971)

vchuravy · 2021-01-22T03:46:04Z

@nanosoldier runtests(ALL, vs = ":release-1.5")

vchuravy · 2021-01-22T03:46:14Z

@nanosoldier runbenchmarks(ALL, vs = ":release-1.5")

nanosoldier · 2021-01-22T04:18:51Z

Something went wrong when running your job:

NanosoldierError: failed to run benchmarks against primary commit: failed process: Process(`/home/nanosoldier/workdir/jl_g4mXAp/julia -e 'VERSION >= v"0.7.0-DEV.3656" && using Pkg; Pkg.update()'`, ProcessExited(1)) [1]

Logs and partial data can be found here
cc @christopher-dG

nanosoldier · 2021-01-22T09:22:00Z

Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

JeffBezanson · 2021-01-22T22:30:06Z

Needs this change:

--- a/base/lock.jl
+++ b/base/lock.jl
@@ -87,7 +87,7 @@ function lock(rl::ReentrantLock)
         if rl.reentrancy_cnt == 0
             rl.locked_by = t
             rl.reentrancy_cnt = 1
-            GC.enable_finalizers()
+            GC.disable_finalizers()
             break
         elseif t === notnothing(rl.locked_by)

Backport of https://github.com/JuliaLang/julia/pull/39038/files

helps #38947 (cherry picked from commit 58d5b00)

(cherry picked from commit 43c7d02)

vchuravy · 2021-01-25T03:08:30Z

@nanosoldier runtests(ALL, vs = ":release-1.5")

nanosoldier · 2021-01-25T08:39:40Z

Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

1951: build sysimg but don't fail on error, disable running tests with sysimg until 1.5.4 bugfix r=jakebolewski a=jakebolewski ### Description Due to bugs in the julia 1.5.(2,3) runtime, the CI sysimg build is currently broken. Disable until Julia v1.5.4 with included bugfixes is released JuliaLang/julia#39351. Co-authored-by: Jake Bolewski <jakebolewski@gmail.com>

This a component of #36929 which happens to fix building on FreeBSD 11. Co-authored-by: Keno Fischer <keno@juliacomputing.com>

This fixes the build on FreeBSD 11 with `LLVM_ASSERTIONS=1`. Co-Authored-By: Valentin Churavy <v.churavy@gmail.com>

Sacha0 · 2021-02-26T00:20:03Z

Thanks folks! ❤️

…ease-1.5 Backports 1.5.4

NHDaly and others added 6 commits January 21, 2021 10:36

Fix segfault in static_show, by using correct vt instead of `typeof…

fd3af72

…(v)` (#38399) This fixes a segfault introduced in #38049. (cherry picked from commit b602577)

update to utf8proc 2.6 (#38551)

fd30588

* update to utf8proc 2.6 * another test (cherry picked from commit 6fbee29)

update to utf8proc 2.6.1 (#38900)

65f39a7

(cherry picked from commit 2362037)

aotcompile: avoid cache lookup when disallowed (#39265)

ae8c3a0

Fix #38548 (cherry picked from commit 29f2f89)

Merge pull request #38679 from JuliaLang/tb/excstack_without_handler

4f70156

Report the top of the exception stack when there's no handler. ------- Backport #38679 into release-1.5

NHDaly mentioned this pull request Jan 21, 2021

Manual backports into backports-release-1.5 #39356

Merged

NHDaly reviewed Jan 21, 2021

View reviewed changes

vtjnash and others added 7 commits January 21, 2021 22:44

fix fields description of Module type (#37645)

24a4637

The fields are not accessible, so it is awkward to report they exist. Fixes #37630 Caused issues starting with #34804

fix #38386, macro defining empty function with escaped name (#38402)

d179f48

fix #37872, avoid cycles in codegen for ===

b9ba10a

(cherry picked from commit 57e2ac9)

fix #37880, overflow in shift amount range check in codegen (#37891)

a4ac1f9

(cherry picked from commit 0a04f41)

coverage: ensure definition line is also counted

7b05f42

Closes #36825 (cherry picked from commit 8aaf971)

vchuravy force-pushed the backports-release-1.5 branch from 790298e to 7b05f42 Compare January 22, 2021 03:45

[release-1.5] Backport libuv patch to include DELETE winacl patch

8684c3d

Backport of https://github.com/JuliaLang/julia/pull/39038/files

JeffBezanson added 2 commits January 24, 2021 22:07

improve performance of disabling finalizers in locks

1c3326f

helps #38947 (cherry picked from commit 58d5b00)

fix failing enable_finalizers test

cb75d49

(cherry picked from commit 43c7d02)

vchuravy force-pushed the backports-release-1.5 branch from 0462e38 to cb75d49 Compare January 25, 2021 03:08

jakebolewski mentioned this pull request Jan 26, 2021

build sysimg but don't fail on error, disable running tests with sysimg until 1.5.4 bugfix CliMA/ClimateMachine.jl#1951

Merged

4 tasks

jakebolewski mentioned this pull request Jan 26, 2021

Re-enable Sysimg CI build when Julia v1.5.4 is released. CliMA/ClimateMachine.jl#1952

Closed

ararslan and others added 2 commits February 19, 2021 14:55

Set NDEBUG when LLVM assertions are disabled

c39f8c5

This a component of #36929 which happens to fix building on FreeBSD 11. Co-authored-by: Keno Fischer <keno@juliacomputing.com>

Correctly propagate LLVM assert flags with BB

81c044a

This fixes the build on FreeBSD 11 with `LLVM_ASSERTIONS=1`. Co-Authored-By: Valentin Churavy <v.churavy@gmail.com>

ararslan merged commit 4b0a7e3 into release-1.5 Feb 25, 2021

ararslan deleted the backports-release-1.5 branch February 25, 2021 21:50

vchuravy pushed a commit to JuliaLang/Test.jl that referenced this pull request Oct 7, 2023

Merge pull request JuliaLang/julia#39351 from JuliaLang/backports-rel…

dbe0e8f

…ease-1.5 Backports 1.5.4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backports 1.5.4 #39351

Backports 1.5.4 #39351

vchuravy commented Jan 21, 2021 •

edited by ararslan

Loading

NHDaly commented Jan 21, 2021 •

edited

Loading

giordano commented Jan 21, 2021

Sacha0 commented Jan 21, 2021 •

edited

Loading

Sacha0 commented Jan 21, 2021

Sacha0 commented Jan 21, 2021 •

edited

Loading

Sacha0 commented Jan 21, 2021

Sacha0 commented Jan 21, 2021

Sacha0 commented Jan 21, 2021

NHDaly Jan 21, 2021

NHDaly Jan 21, 2021 •

edited

Loading

Sacha0 Jan 21, 2021

vchuravy commented Jan 22, 2021

vchuravy commented Jan 22, 2021

nanosoldier commented Jan 22, 2021

nanosoldier commented Jan 22, 2021

JeffBezanson commented Jan 22, 2021

vchuravy commented Jan 25, 2021

nanosoldier commented Jan 25, 2021

Sacha0 commented Feb 26, 2021

	if (s0 isa Type && s0 == Type{Union{}}) \|\| isa(s0, Conditional)
	if s0 == Type{Union{}} \|\| isa(s0, Conditional)

Backports 1.5.4 #39351

Backports 1.5.4 #39351

Conversation

vchuravy commented Jan 21, 2021 • edited by ararslan Loading

NHDaly commented Jan 21, 2021 • edited Loading

giordano commented Jan 21, 2021

Sacha0 commented Jan 21, 2021 • edited Loading

Sacha0 commented Jan 21, 2021

Sacha0 commented Jan 21, 2021 • edited Loading

Sacha0 commented Jan 21, 2021

Sacha0 commented Jan 21, 2021

Sacha0 commented Jan 21, 2021

NHDaly Jan 21, 2021

Choose a reason for hiding this comment

NHDaly Jan 21, 2021 • edited Loading

Choose a reason for hiding this comment

Sacha0 Jan 21, 2021

Choose a reason for hiding this comment

vchuravy commented Jan 22, 2021

vchuravy commented Jan 22, 2021

nanosoldier commented Jan 22, 2021

nanosoldier commented Jan 22, 2021

JeffBezanson commented Jan 22, 2021

vchuravy commented Jan 25, 2021

nanosoldier commented Jan 25, 2021

Sacha0 commented Feb 26, 2021

vchuravy commented Jan 21, 2021 •

edited by ararslan

Loading

NHDaly commented Jan 21, 2021 •

edited

Loading

Sacha0 commented Jan 21, 2021 •

edited

Loading

Sacha0 commented Jan 21, 2021 •

edited

Loading

NHDaly Jan 21, 2021 •

edited

Loading