cmdlineargs test: on 32-bit systems, impose a constant upper limit on the number of threads #39854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the number of threads
vtjnash
approved these changes
Feb 28, 2021
|
Hopefully this fixes the test failures on Edit: looks like it did fix those failures, at least for now. |
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
… the number of threads (JuliaLang#39854)
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
… the number of threads (JuliaLang#39854)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, if the computer has e.g. 200 CPU threads, then the
cmdlinearargstest will use 400 threads.After this PR, on 32-bit systems, the
cmdlinearargswill never use more than 50 threads.The behavior on 64-bit systems is unchanged.