Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concatenation with UniformScaling and numbers #41394

Merged
merged 5 commits into from
Jul 4, 2021
Merged

Concatenation with UniformScaling and numbers #41394

merged 5 commits into from
Jul 4, 2021

Conversation

dkarrasch
Copy link
Member

Rebase of #33363.

This allows to concatenate matrices, numbers and uniform scalings.

Fixes JuliaLang/LinearAlgebra.jl#666. Closes #33363.

@dkarrasch dkarrasch added arrays [a, r, r, a, y, s] linear algebra Linear algebra labels Jun 28, 2021
@dkarrasch dkarrasch requested review from mbauman and stevengj June 29, 2021 15:52
vtjnash
vtjnash approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made your comment into a suggestion. If you approve/commit that, I think we can immediately merge (i.e. add the merge-me tag)

stdlib/LinearAlgebra/src/uniformscaling.jl Show resolved Hide resolved
@dkarrasch @vtjnash
Update stdlib/LinearAlgebra/src/uniformscaling.jl
8fd2450 
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@dkarrasch dkarrasch added the merge me PR is reviewed. Merge when all tests are passing label Jul 2, 2021
@dkarrasch dkarrasch merged commit 18f2f9f into master Jul 4, 2021
@dkarrasch dkarrasch deleted the dk/uf_cat branch July 4, 2021 09:36
@dkarrasch dkarrasch removed the merge me PR is reviewed. Merge when all tests are passing label Jul 4, 2021
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@dkarrasch @vtjnash @johanmon
Concatenation with UniformScaling and numbers (JuliaLang#41394)
f49a7ae 
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@dkarrasch dkarrasch mentioned this pull request Jul 8, 2021
Merged
@JeffBezanson
Copy link
Member

Interestingly (for the type system), this made the humble call methods(hvcat, (Tuple{Int,Int},Any,Any,Any,Any,Any,Any,Int,Int)) take >50 seconds, which also affects some compile times.

@JeffBezanson JeffBezanson mentioned this pull request Jul 8, 2021
Closed
@dkarrasch
Copy link
Member Author

dkarrasch commented Jul 22, 2021 •
edited
Loading

@JeffBezanson So how do we handle this slowdown? #41511 is a small PR on top of this one to avoid method ambiguities. Are we going to keep this one here and try to improve it or revert it and tackle the issue from scratch with latency checks included?

Scratch that, I just saw that #41511 already has a triage label.

@dkarrasch dkarrasch mentioned this pull request Mar 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengj stevengj stevengj left review comments

@vtjnash vtjnash vtjnash approved these changes

@mbauman mbauman Awaiting requested review from mbauman

Assignees
No one assigned
Labels
arrays [a, r, r, a, y, s] linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concatenation with I (UniformScaling) fails with numbers
4 participants
@dkarrasch @JeffBezanson @vtjnash @stevengj