Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only load extension triggers from the evnironment where the parent package is loaded #48703

Merged
merged 1 commit into from
Feb 20, 2023
Merged

only load extension triggers from the evnironment where the parent package is loaded #48703

merged 1 commit into from
Feb 20, 2023

Conversation

KristofferC
Copy link
Sponsor Member

@KristofferC KristofferC commented Feb 17, 2023 •
edited
Loading

If you had package A with ext Bext in your global env and another version of package A with ext Bext2 in your active env, trying to load A and B would cause Bext to be attempted to be loaded which it shouldn't.

This fixes the bug and sets up a stacked env in the test replicating the scenario above.

Reported by @termi-official

@KristofferC KristofferC added packages Package management and loading backport 1.9 Change should be backported to release-1.9 labels Feb 17, 2023
@KristofferC KristofferC merged commit 200c962 into master Feb 20, 2023
@KristofferC KristofferC deleted the kc/ext_trigger_env branch February 20, 2023 08:49
@KristofferC KristofferC mentioned this pull request Feb 20, 2023
Merged
50 tasks
KristofferC added a commit that referenced this pull request Feb 20, 2023
@KristofferC
only load extension triggers from the evnironment where the parent pa…
3d45a6b 
…ckage is loaded (#48703)

(cherry picked from commit 200c962)
@KristofferC KristofferC mentioned this pull request Feb 20, 2023
Open
KristofferC added a commit that referenced this pull request Feb 20, 2023
@KristofferC
only load extension triggers from the evnironment where the parent pa…
06d04df 
…ckage is loaded (#48703)

(cherry picked from commit 200c962)
KristofferC added a commit that referenced this pull request Feb 21, 2023
@KristofferC
only load extension triggers from the evnironment where the parent pa…
e6f6e7c 
…ckage is loaded (#48703)

(cherry picked from commit 200c962)
KristofferC added a commit that referenced this pull request Feb 21, 2023
@KristofferC
only load extension triggers from the evnironment where the parent pa…
f61f107 
…ckage is loaded (#48703)

(cherry picked from commit 200c962)
KristofferC added a commit that referenced this pull request Feb 21, 2023
@KristofferC
only load extension triggers from the evnironment where the parent pa…
5453936 
…ckage is loaded (#48703)

(cherry picked from commit 200c962)
@visr visr mentioned this pull request Feb 21, 2023
Closed
@devmotion devmotion mentioned this pull request Feb 22, 2023
Closed
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Mar 6, 2023
@devmotion devmotion mentioned this pull request Mar 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
packages Package management and loading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KristofferC