SROA: don't use unswitchtupleunion and explicitly use type name only
#50522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
force-pushed
the
avi/follow-up-50502
branch
from
8f666cf to
279cbef
Compare
vtjnash
reviewed
Jul 12, 2023
base/compiler/ssair/passes.jl
Outdated
| if !((field_ordering === :unspecified) || | ||
| (field_ordering isa Const && field_ordering.val === :not_atomic)) | ||
| continue | ||
| end | ||
|
|
||
| # analyze this mutable struct here for the later pass | ||
| if ismutabletype(struct_typ_unwrapped) | ||
| if struct_typ_name.flags & 0x2 == 0x2 # if this struct is mutable |
There was a problem hiding this comment.
ismutabletype(struct_typ_unwrapped.wrapper)
The flags field is very unstable, so it is a bad idea to hard code assumptions about it.
There was a problem hiding this comment.
struct_typ_name.wrapper is UnionAll so it is not applicable to ismutabletype. We probably want to define ismutabletypename?
vtjnash
approved these changes
Jul 12, 2023
Since construction of `UnionAll` of `Union`s can be expensive. The SROA pass just needs to look at type name information and do not need to propagate full type objects. - xref: <#50511 (comment)> - closes #50511
aviatesk
force-pushed
the
avi/follow-up-50502
branch
from
279cbef to
14069ff
Compare
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
Keno
added a commit
that referenced
this pull request
Jul 14, 2023
Fixes the issue noted in [1] (#50522) and adds a test to make sure that it doesn't regress. [1] 9b73611#r121641452
aviatesk
pushed a commit
that referenced
this pull request
Jul 15, 2023
Fixes the issue noted in [1] (#50522) and adds a test to make sure that it doesn't regress. [1] 9b73611#r121641452
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 15, 2023
Fixes the issue noted in [1] (#50522) and adds a test to make sure that it doesn't regress. [1] 9b73611#r121641452
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since construction of
UnionAllofUnions can be expensive. The SROA pass just needs to look at type name information and do not need to propagate full type objects.unswitchtupleunionoptimization" #50511 (comment)unswitchtupleunionoptimization" #50511