Thread-safety: disable internal storage by default #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The README now describes optimizations and issues they cause for thread-safety. The constructor now allows one to disable these optimization by passing `allocatetmp=false`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #43 +/- ##
==========================================
+ Coverage 99.50% 99.52% +0.01%
==========================================
Files 4 4
Lines 204 212 +8
==========================================
+ Hits 203 211 +8
Misses 1 1 ☔ View full report in Codecov by Sentry. |
Better to be safe than optimized
timholy
force-pushed
the
teh/thread_safety
branch
from
feaf05e
to
0b682a2
Compare
timholy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README now describes optimizations and the issues they cause for thread-safety. The constructor now defaults to avoiding these optimizations, but allows them to be turned on with
allocatetmp=true.