Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve_exp_ode does not ever update position #744

Closed
r0uv3n opened this issue Sep 12, 2024 · 3 comments · Fixed by #748
Closed

solve_exp_ode does not ever update position #744

r0uv3n opened this issue Sep 12, 2024 · 3 comments · Fixed by #748
Labels
bug Something isn't working

Comments

@r0uv3n
Copy link
Contributor

r0uv3n commented Sep 12, 2024

solve_exp_ode seems to always return the starting point p for any input. See e.g.

using Manifolds
using OrdinaryDiffEq
E = Euclidean(3)
p = [0, 0, 0] # point in E
A = get_default_atlas(E)
i = Manifolds.get_chart_index(E, A, p)
B = Manifolds.induced_basis(E, A, i, TangentSpaceType())
X = [0, 0, 1] # tangent vector
time = 1

Manifolds.solve_exp_ode(E, p, X, time; basis=B)

which returns [0, 0, 0] (i.e. just the starting point p).

@r0uv3n
Copy link
Contributor Author

r0uv3n commented Sep 12, 2024

This seems to be due to a small typo in

q = sol.u[1][(n + 1):(2 * n)]
where the first element instead of the last element of the solution u is accessed.

@kellertuer
Copy link
Member

If you see how this can be fixed, feel free to also open a PR for this. Otherwise, probably Mateusz will step in, he I´might just be a bit busy currently, maybe.

@mateuszbaran
Copy link
Member

Right, sorry for the mistake, I will fix that this weekend.

@mateuszbaran mateuszbaran added the bug Something isn't working label Sep 13, 2024
r0uv3n added a commit to r0uv3n/Manifolds.jl that referenced this issue Sep 14, 2024
r0uv3n added a commit to r0uv3n/Manifolds.jl that referenced this issue Sep 14, 2024
kellertuer pushed a commit that referenced this issue Sep 15, 2024
* Fix  solve_exp_ode doc string

Fixes #740

* Implement failing test for #744

* Fix`solve_exp_ode` does not ever update position #744

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants