-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Float64->UInt8 unexpectedly get affected in v0.7.0 #164
Comments
I'm checking just to be sure, but this is not the difference on julia> for x=0:255; x*(1/255) == x/255 || @show x; end
x = 33
x = 37
x = 41
x = 45
x = 49
x = 53
x = 57
x = 61
x = 66
x = 74
x = 82
x = 90
x = 98
x = 106
x = 114
x = 122
x = 132
x = 148
x = 164
x = 180
x = 196
x = 212
x = 228
x = 244 |
You got it! I really should have checked that yesterday. The saved JLD files of julia> euclidean(img06, img07)
1.0021492566079894e-14 Should users be worried about this? Probably no I guess. |
I think it depends on the usage or purpose. For example, it can be problematic in the tamper detection or steganography. However, I don't think it is necessary to reduce accuracy for the compatibility. In any case, ReferenceTests.jl is working correctly. |
Could you point me to the PR where the behavior of |
FixedPointNumbers.jl/src/normed.jl Lines 170 to 179 in 402e637
|
These lines are spells to me but I trust you that's making things better 😃 . I'm closing this now. |
The accuracy of N0f8->Float64 conversion is improved in FixedPointNumbers v0.7 cf: JuliaMath/FixedPointNumbers.jl#164
The accuracy of N0f8->Float64 conversion is improved in FixedPointNumbers v0.7 cf: JuliaMath/FixedPointNumbers.jl#164
Any ideas of how the results are changed upgrading from v0.6.1 to v0.7.0? I'll check that later if nobody does... (Catching a cold now and my mind goes blank...)
Here is the minimal codes I can provide so far:
c.f. JuliaTesting/ReferenceTests.jl#46
The text was updated successfully, but these errors were encountered: