Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also map the dependencies of stdlibs #9

Closed
IanButterworth opened this issue Nov 25, 2022 · 2 comments · Fixed by JuliaLang/Pkg.jl#3911
Closed

Also map the dependencies of stdlibs #9

IanButterworth opened this issue Nov 25, 2022 · 2 comments · Fixed by JuliaLang/Pkg.jl#3911

Comments

@IanButterworth
Copy link
Member

IanButterworth commented Nov 25, 2022 •
edited
Loading

We currently only store a julia version to stdlib map, but the deps of the stdlibs themselves also need to be resolved afaik.

@KristofferC has talked about this before. I don't fully understand what is needed both here and in Pkg to handle this

cc. @giordano @staticfloat
@mkitti mkitti mentioned this issue Mar 2, 2024
Open
@KristofferC
Copy link
Member

I don't fully understand what is needed both here and in Pkg to handle this

For a given stdlib and a given julia version we need the set of deps (+ weakdeps) to inject here: https://github.com/JuliaLang/Pkg.jl/blob/d1f91fd37111aacd056a99b5f8c9315b578ae285/src/Operations.jl#L523C15-L540 instead of looking at the project file for the stdlib bundled with the current Julia.

@IanButterworth
Copy link
Member Author

Would a correct way to do this be to just get the required version julia exe (via juliaup?) and query it as a subprocess for the list?

I don't think we need this lookup to be really fast?

staticfloat added a commit to JuliaLang/Pkg.jl that referenced this issue Jun 3, 2024
@staticfloat
Use historical stdlib dependency information
8dcf555 
This makes use of the new functionality in HistoricalStdlibVersions [0]
to properly pull out the dependency information in old stdlibs.  This
fixes JuliaPackaging/HistoricalStdlibVersions.jl#9.

[0] JuliaPackaging/HistoricalStdlibVersions.jl#23
@staticfloat staticfloat mentioned this issue Jun 3, 2024
Merged
staticfloat added a commit to JuliaLang/Pkg.jl that referenced this issue Jun 3, 2024
@staticfloat
Use historical stdlib dependency information
7a7b9ac 
This makes use of the new functionality in HistoricalStdlibVersions [0]
to properly pull out the dependency information in old stdlibs.  This
fixes JuliaPackaging/HistoricalStdlibVersions.jl#9.

[0] JuliaPackaging/HistoricalStdlibVersions.jl#23
staticfloat added a commit to JuliaLang/Pkg.jl that referenced this issue Jun 3, 2024
@staticfloat
Use historical stdlib dependency information
12cc410 
This makes use of the new functionality in HistoricalStdlibVersions [0]
to properly pull out the dependency information in old stdlibs.  This
fixes JuliaPackaging/HistoricalStdlibVersions.jl#9.

[0] JuliaPackaging/HistoricalStdlibVersions.jl#23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use historical stdlib dependency information JuliaLang/Pkg.jl
2 participants
@KristofferC @IanButterworth