Rewrite for dependency tracking #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
added a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Jun 3, 2024
This makes use of the new functionality in HistoricalStdlibVersions [0] to properly pull out the dependency information in old stdlibs. This fixes JuliaPackaging/HistoricalStdlibVersions.jl#9. [0] JuliaPackaging/HistoricalStdlibVersions.jl#23
staticfloat
force-pushed
the
sf/track_deps
branch
from
956ee65
to
97008a5
Compare
This significantly reworks the datastructures used to encode the historical stdlib data, so that we can include dependencies and weak dependencies for all stdlib versions. This will be used by Pkg to properly resolve transitive dependencies of stdlibs. This also changes `HistoricalStdlibVersions` to register the data structures with `Pkg` on load. This simplifies things greatly, and also allows us to maintain a single location that knows how to deal with multiple different `Pkg` versions, as only Julia v1.12+ will know how to use the newer datastructures here.
staticfloat
force-pushed
the
sf/track_deps
branch
from
97008a5
to
5e3cf43
Compare
staticfloat
added a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Jun 3, 2024
This makes use of the new functionality in HistoricalStdlibVersions [0] to properly pull out the dependency information in old stdlibs. This fixes JuliaPackaging/HistoricalStdlibVersions.jl#9. [0] JuliaPackaging/HistoricalStdlibVersions.jl#23
staticfloat
force-pushed
the
sf/track_deps
branch
from
5e3cf43
to
308969d
Compare
staticfloat
added a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Jun 3, 2024
This makes use of the new functionality in HistoricalStdlibVersions [0] to properly pull out the dependency information in old stdlibs. This fixes JuliaPackaging/HistoricalStdlibVersions.jl#9. [0] JuliaPackaging/HistoricalStdlibVersions.jl#23
KristofferC
pushed a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Jul 12, 2024
* Use historical stdlib dependency information This makes use of the new functionality in HistoricalStdlibVersions [0] to properly pull out the dependency information in old stdlibs. This fixes JuliaPackaging/HistoricalStdlibVersions.jl#9. [0] JuliaPackaging/HistoricalStdlibVersions.jl#23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly reworks the datastructures used to encode the historical stdlib data, so that we can include dependencies and weak dependencies for all stdlib versions. This will be used by Pkg to properly resolve transitive dependencies of stdlibs.
This also changes
HistoricalStdlibVersionsto register the data structures withPkgon load. This simplifies things greatly, and also allows us to maintain a single location that knows how to deal with multiple differentPkgversions, as only Julia v1.12+ will know how to use the newer datastructures here.