[LLVM_full@12] Add LLVM AArch64 unwind patches #3221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
added
julia 💜 ❤️ 💚
|
@topolarity any idea about the MacOS build failure? @giordano which libc++ are we building against? |
You mean |
giordano
reviewed
Jun 29, 2021
vchuravy
commented
Jun 29, 2021
giordano
reviewed
Jun 29, 2021
| @@ -28,19 +28,19 @@ uuid = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f" | |||
|
|
|||
There was a problem hiding this comment.
To be clear, I don't think this is a good long-term solution. I'll need to update BinaryBuilderBase for #3229 for example (we need JuliaPackaging/BinaryBuilderBase.jl#156). What if we move csl_paths(host_platform) at the beginning of LD_LIBRARY_PATH instead? @staticfloat?
vchuravy
force-pushed
the
ct/llvmfde_aarch64
branch
from
0d0ff6b to
f7beab5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting out the LLVM 12 patches from #3063