[Runner] Fix value of LD environment variable for macOS
#156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
commented
Jun 29, 2021
| @@ -979,7 +979,7 @@ function platform_envs(platform::AbstractPlatform, src_name::AbstractString; | |||
|
|
|||
| # If we're on macOS, we give a hint to things like `configure` that they should use this as the linker | |||
| if Sys.isapple(platform) | |||
| mapping["LD"] = "/opt/$(target)/bin/ld64.macos" | |||
There was a problem hiding this comment.
@staticfloat why was this set to this value? There is no such file in our environment:
sandbox:${WORKSPACE} # qfind /opt -name "ld64*"
/opt/bin/x86_64-apple-darwin14-libgfortran3-cxx03/ld64.x86_64-apple-darwin14
There was a problem hiding this comment.
Hmmmm...... looks like I stopped doing this in JuliaPackaging/Yggdrasil@d787aa2#diff-37a7da7ede42eaf0bfe29fb575ba5a7450bbc8a3621dd2a9d758fb04c749d07cL648, but I don't remember what allowed me to get rid of it. In any case, if this passes the shard testsuite, I'm okay with it.
There was a problem hiding this comment.
I don't think the macOS linker is used anywhere in our tests, since at the moment this is broken:
sandbox:${WORKSPACE} # echo ${LD}
/opt/x86_64-apple-darwin14/bin/ld64.macos
sandbox:${WORKSPACE} # ls ${LD}
ls: /opt/x86_64-apple-darwin14/bin/ld64.macos: No such file or directory🙂
This was referenced Jun 29, 2021
staticfloat
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.