Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove constraint on macOS of QuantumEspresso_jll #3535

Merged
merged 3 commits into from
Sep 3, 2021
Merged

Remove constraint on macOS of QuantumEspresso_jll #3535

merged 3 commits into from
Sep 3, 2021

Conversation

singularitti
Copy link
Contributor

@singularitti singularitti commented Aug 22, 2021 •
edited
Loading

Can the restriction be removed for QuantumEspresso now since JuliaPackaging/BinaryBuilderBase.jl#156 was merged? I really need to install it on macOS. If so, please merge this.

@singularitti
Copy link
Contributor Author

Does not seem to be successful😂

@singularitti
Copy link
Contributor Author

singularitti commented Aug 22, 2021 •
edited
Loading

Did you figure out why it cannot build on macOS @mfherbst? I really want to use them on Macs.

@mfherbst
Copy link
Contributor

mfherbst commented Aug 22, 2021 •
edited
Loading

Did you figure out why it cannot build on macOS @mfherbst? I really want to use them on Macs.

It's to do with the fact that we are doing a cross-compilation for which the QE build scripts were never made. Apparently switching to CMake in the next QE release should make mac os possible according to the QE devs.

Otherwise major massaging of the QE build scripts could also do the trick, but I did not have the will or time to do that juggling. But feel free to give it a try @singularitti ...

@giordano
Copy link
Member

Can we consolidate this PR and #3538? Building twice this large package is a huge waste of resources

@singularitti
Copy link
Contributor Author

Can we consolidate this PR and #3538? Building twice this large package is a huge waste of resources

Sure, sorry for the waste. I will discuss the name with @mfherbst in a few days.

@singularitti singularitti mentioned this pull request Sep 1, 2021
Merged
@singularitti
Copy link
Contributor Author

Can we also merge this since #3538 was merged?

@staticfloat staticfloat merged commit 8ed2ce1 into JuliaPackaging:master Sep 3, 2021
simeonschaub pushed a commit to simeonschaub/Yggdrasil that referenced this pull request Feb 23, 2022
@singularitti @giordano @simeonschaub
Remove constraint on macOS of QuantumEspresso_jll (JuliaPackaging#3535
14e3352 
)

* Remove constraint on macOS

* [QuantumEspresso] Empty `LD`

* [QuantumEspresso] Make executable all files in bindir

Co-authored-by: Mosè Giordano <mose@gnu.org>
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@singularitti @mfherbst @giordano @staticfloat