[libsingular_julia] update to v0.21

[tthsqe12]

No description provided.

[giordano]

Sigh, also this one is blocked by JuliaLang/Pkg.jl#2942.

[tthsqe12]

let's try again

[giordano]

Ok, this now works for Julia 1.7+. Maybe drop Julia v1.6?

[tthsqe12]

I don't think we can do that. @thofma @fingolfin

[thofma]

No, we can't. The offending package he cannot find is
https://github.com/JuliaRegistries/General/blob/ae85bd68a65412602ab29733c890954e9944b744/L/LibOSXUnwind_jll/Package.toml
Why would this be related?

[giordano]

It's explained in JuliaLang/Pkg.jl#2942 (comment). LibOSXUnwind_jll used to be a stdlib and a dependency of libjulia_jll, but now that's no longer a stdlib (I didn't know we were allowed to remove stdlibs, and indeed that wreaks havoc)

[thofma]

Thanks, I (thankfully?) missed the recent fun. Is this just a problem during the build here and if so, can we just build and deploy using 1.6?

[giordano]

We moved to Julia v1.7 in #4261, I'd rather not go back to Julia v1.6. We should look into a workaround for the problem in Pkg.

[thofma]

OK, thanks for looking into this. I guess we will have to wait.

[fingolfin]

Urgh. This is bad.

I mean in theory, we could go back to building everything twice, this time once for 1.6 and once for >= 1.7. But we worked so hard to avoid just that! And it seems so silly...

The annoying part is that LibOSXUnwind_jll is only a dependency because libunwind.h is included in julia_internal.h and again in julia_threads.h. This wouldn't matter for users of libjulia_jll though if julia.h didn't include those headers...

Actually I think the include in julia_threads.h could simply be removed (no unw_* / UNW_ symbols are used in it). And julia_internal.h is not even included from julia.h (and arguably that's what project using libjulia_jll care about).

[giordano]

For the record, I was hoping we could work around the issue with

    BuildDependency(get_addable_spec("LibOSXUnwind_jll", v"0.0.6+1");
                    platforms=filter(p -> p["julia_version"]=="1.6.0", platforms)),

but in this way I get a different error

ERROR: LoadError: IOError: mkdir("/usr/share/julia/stdlib/v1.7/LibOSXUnwind_jll"; mode=0o777): permission denied (EACCES)
Stacktrace:
  [1] uv_error
    @ ./libuv.jl:97 [inlined]
  [2] mkdir(path::String; mode::UInt16)
    @ Base.Filesystem ./file.jl:183
  [3] mkpath(path::String; mode::UInt16)
    @ Base.Filesystem ./file.jl:234
  [4] mkpath
    @ ./file.jl:229 [inlined]
  [5] (::Pkg.Types.var"#42#43"{Pkg.Types.Context, Pkg.Types.PackageSpec, String})(repo::GitRepo)
    @ Pkg.Types /usr/share/julia/stdlib/v1.7/Pkg/src/Types.jl:732
  [6] with(f::Pkg.Types.var"#42#43"{Pkg.Types.Context, Pkg.Types.PackageSpec, String}, obj::GitRepo)
    @ LibGit2 /usr/share/julia/stdlib/v1.7/LibGit2/src/types.jl:1150
  [7] handle_repo_add!(ctx::Pkg.Types.Context, pkg::Pkg.Types.PackageSpec)
    @ Pkg.Types /usr/share/julia/stdlib/v1.7/Pkg/src/Types.jl:676
  [8] handle_repos_add!(ctx::Pkg.Types.Context, pkgs::Vector{Pkg.Types.PackageSpec})
    @ Pkg.Types /usr/share/julia/stdlib/v1.7/Pkg/src/Types.jl:743
  [9] add(ctx::Pkg.Types.Context, pkgs::Vector{Pkg.Types.PackageSpec}; preserve::Pkg.Types.PreserveLevel, platform::Platform, kwargs::Base.Pairs{Symbol, Base.TTY, Tuple{Symbol}, NamedTuple{(:io,), Tuple{Base.TTY}}})
    @ Pkg.API /usr/share/julia/stdlib/v1.7/Pkg/src/API.jl:248
 [10] (::BinaryBuilderBase.var"#88#94"{Bool, Prefix, Vector{Pkg.Types.PackageSpec}, Platform, Vector{String}, Vector{String}})()
    @ BinaryBuilderBase ~/.julia/dev/BinaryBuilderBase/src/Prefix.jl:572
 [11] activate(f::BinaryBuilderBase.var"#88#94"{Bool, Prefix, Vector{Pkg.Types.PackageSpec}, Platform, Vector{String}, Vector{String}}, new_project::String)
    @ Pkg.API /usr/share/julia/stdlib/v1.7/Pkg/src/API.jl:1599
 [12] setup_dependencies(prefix::Prefix, dependencies::Vector{Pkg.Types.PackageSpec}, platform::Platform; verbose::Bool)
    @ BinaryBuilderBase ~/.julia/dev/BinaryBuilderBase/src/Prefix.jl:565
 [13] (::BinaryBuilder.var"#setup_deps#27")(f::typeof(BinaryBuilderBase.is_target_dependency), prefix::Prefix, dependencies::Vector{BinaryBuilderBase.AbstractDependency}, platform::Platform, verbose::Bool)
    @ BinaryBuilder ~/.julia/dev/BinaryBuilder/src/AutoBuild.jl:754
 [14] autobuild(dir::AbstractString, src_name::AbstractString, src_version::VersionNumber, sources::Vector{<:BinaryBuilderBase.AbstractSource}, script::AbstractString, platforms::Vector, products::Vector{<:Product}, dependencies::Vector{<:BinaryBuilderBase.AbstractDependency}; verbose::Bool, debug::Bool, skip_audit::Bool, ignore_audit_errors::Bool, autofix::Bool, code_dir::Union{Nothing, String}, require_license::Bool, kwargs::Base.Pairs{Symbol, V, Tuple{Vararg{Symbol, N}}, NamedTuple{names, T}} where {V, N, names, T<:Tuple{Vararg{Any, N}}})
    @ BinaryBuilder ~/.julia/dev/BinaryBuilder/src/AutoBuild.jl:757
 [15] build_tarballs(ARGS::Any, src_name::Any, src_version::Any, sources::Any, script::Any, platforms::Any, products::Any, dependencies::Any; julia_compat::String, kwargs::Base.Pairs{Symbol, V, Tuple{Vararg{Symbol, N}}, NamedTuple{names, T}} where {V, N, names, T<:Tuple{Vararg{Any, N}}})
    @ BinaryBuilder ~/.julia/dev/BinaryBuilder/src/AutoBuild.jl:321
 [16] top-level scope
    @ ~/repo/Yggdrasil/L/libsingular_julia/build_tarballs.jl:58
in expression starting at /home/mose/repo/Yggdrasil/L/libsingular_julia/build_tarballs.jl:58

[giordano]

I can confirm the hack above works nicely when using Julia master. We may have to upgrade the julia version we use in Yggdrasil.

[thofma]

@giordano Do you think there is a solution in sight?

[giordano]

Trying to find a working solution in JuliaPackaging/BinaryBuilderBase.jl#212, without much success so far though

[fingolfin]

I hope we can address this by adjusting libjulia_jll to not depend on LibOSXUnwind_jll anymore, see the WIP in #4320 .

[giordano]

That'd also be great, yes

[fingolfin]

Until we have a "proper" solution, perhaps the same hack workaround as used in #4264 can be used to make this JLL build again. Until we have a proper fix -- this way, at least we can go on with work on Singular etc.

[thofma]

I would be in favour of this.

[thofma]

Looks good to me. Maybe @fingolfin could also have a quick glance.

[fingolfin]

Thanks!