Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libjulia_jll: turn LibOSXUnwind_jll into a build dep for Julia 1.6 #4320

Merged
merged 4 commits into from
Feb 20, 2022

Conversation

fingolfin
Copy link
Member

This is experimental. I still need to verify that the result can
be used to build other JLLs using libjulia_jll. But I thought
it'd be good to already collect feedback here.

[skip ci] [skip build]

L/libjulia/common.jl Outdated Show resolved Hide resolved
L/libjulia/common.jl Outdated Show resolved Hide resolved
@giordano giordano force-pushed the mh/libjulia-1.6-workaround branch from aed07a9 to dc818c0 Compare January 28, 2022 23:14
@fingolfin
Copy link
Member Author

Thanks for working on this @giordano. I've renamed my patch to hopefully fix the cd: too many arguments error. That leaves KeyError: key UUID("a83860b7-747b-57cf-bf1f-3e79990d037f") not found for Julia 1.6.

@giordano
Copy link
Member

Yeah, this is becoming a circular issue...

@fingolfin
Copy link
Member Author

fingolfin commented Jan 29, 2022

:-(.

next idea then: manually download and extract the libunwindOSX artifact, remove it as a builddep. But need sleep first

@fingolfin fingolfin force-pushed the mh/libjulia-1.6-workaround branch 2 times, most recently from 18acfe4 to 2bf85c7 Compare February 18, 2022 16:31
@fingolfin
Copy link
Member Author

@giordano how can I fix this again?

ERROR: LoadError: Unsatisfiable requirements detected for package OpenBLAS_jll [4536629a]:
 OpenBLAS_jll [4536629a] log:
 ├─possible versions are: 0.3.13 or uninstalled
 └─restricted to versions 0.3.10 by an explicit requirement — no versions left

@giordano
Copy link
Member

BinaryBuilderBase.get_addable_spec, I presume.

@fingolfin
Copy link
Member Author

sigh

ERROR: LoadError: Unsatisfiable requirements detected for package libLLVM_jll [8f36deef]:
 libLLVM_jll [8f36deef] log:
 ├─possible versions are: 12.0.1 or uninstalled
 └─restricted to versions 11.0.1 by an explicit requirement — no versions left

@giordano
Copy link
Member

Yeah, they all need to become get_addable_spec. Every time we move forward with the Julia used for the build, old dependences may become uninstallable otherwise.

@fingolfin fingolfin force-pushed the mh/libjulia-1.6-workaround branch 4 times, most recently from 2f8a484 to 6798411 Compare February 20, 2022 10:28
@fingolfin fingolfin marked this pull request as ready for review February 20, 2022 10:28
@fingolfin
Copy link
Member Author

This should be ready. But perhaps should be merged with skip ci, skip build, and then we focus on PR #4461.

It was broken anyway, and not worth fixing at this point. On the up side, this simplifies the code quite a bit
@fingolfin fingolfin force-pushed the mh/libjulia-1.6-workaround branch from 6798411 to 969d845 Compare February 20, 2022 12:25
@giordano giordano merged commit 4cc6e54 into JuliaPackaging:master Feb 20, 2022
@giordano
Copy link
Member

Thanks a lot Max!

@fingolfin fingolfin deleted the mh/libjulia-1.6-workaround branch February 20, 2022 16:38
simeonschaub pushed a commit to simeonschaub/Yggdrasil that referenced this pull request Feb 23, 2022
…uliaPackaging#4320)

* [libjulia] Make all versions proper `VersionNumber`

* [libjulia] Fix git repository URL

* [libjulia] turn LibOSXUnwind_jll into a build dep for Julia 1.6

* [libjulia] Drop support for building Julia <= 1.5

It was broken anyway, and not worth fixing at this point. On the up side, this simplifies the code quite a bit

Co-authored-by: Mosè Giordano <mose@gnu.org>

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants