Skip to content

Commit

Permalink
v1.21.1 | No exception thrown in apply_recipe fallback (#3765)
Browse files Browse the repository at this point in the history 
* No exception thrown in `apply_recipe` fallback

Throwing an exception here can vastly slow down plotting, as it happens frequently. Returning an error value instead, which the calling function can check, can speed up plotting 2x. An accompanying change is necessary in RecipesPipeline.jl, assuming this value is suitable.

* Bumped compat for RecipesPipeline, tentative

* Bump patch version

* Fix wrong versioning

Co-authored-by: t-bltg <tf.bltg@gmail.com>
  • Loading branch information
@BioTurboNick @t-bltg
BioTurboNick and t-bltg authored Aug 26, 2021
1 parent 5afeba6 commit 5acf967
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Plots"
uuid = "91a5bcdd-55d7-5caf-9e0b-520d859cae80"
author = ["Tom Breloff (@tbreloff)"]
version = "1.21.0"
version = "1.21.1"

[deps]
Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"
Expand Down Expand Up @@ -46,7 +46,7 @@ NaNMath = "0.3"
PlotThemes = "2"
PlotUtils = "1"
RecipesBase = "1"
RecipesPipeline = "0.3"
RecipesPipeline = "0.3.5"
Reexport = "0.2, 1.0"
Requires = "1"
Scratch = "1"
Expand Down
2 changes: 1 addition & 1 deletion src/recipes.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ num_series(x::AMat) = size(x, 2)
num_series(x) = 1

RecipesBase.apply_recipe(plotattributes::AKW, ::Type{T}, plt::AbstractPlot) where {T} =
throw(MethodError(T, "Unmatched plot recipe: $T"))
nothing

# ---------------------------------------------------------------------------

Expand Down

2 comments on commit 5acf967

@t-bltg
Copy link
Member

@t-bltg t-bltg commented on 5acf967 Aug 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/43601

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.21.1 -m "<description of version>" 5acf967a9ebf621a7e36f62ee7cb8503b049165b
git push origin v1.21.1

Please sign in to comment.