No exception thrown in apply_recipe fallback
#3765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throwing an exception here can vastly slow down plotting, as it happens frequently. Returning an error value instead, which the calling function can check, can speed up plotting 2x. An accompanying change is necessary in RecipesPipeline.jl, assuming this value is suitable.
BioTurboNick
added a commit
to BioTurboNick/RecipesPipeline.jl
that referenced
this pull request
Aug 25, 2021
For compatibility with JuliaPlots/Plots.jl#3765
|
An alternative would be to have an API to check if a recipe exists prior to applying it, but that would break existing usage I think. |
|
Let's wait a few minutes for JuliaRegistries/General#43596 to be merged. |
Codecov Report
@@ Coverage Diff @@
## master #3765 +/- ##
==========================================
+ Coverage 63.30% 63.34% +0.03%
==========================================
Files 28 28
Lines 7377 7360 -17
==========================================
- Hits 4670 4662 -8
+ Misses 2707 2698 -9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throwing an exception here can vastly slow down plotting, as it happens frequently. Returning an error value instead, which the calling function can check, can speed up plotting 2x. An accompanying change (JuliaPlots/RecipesPipeline.jl#95) is necessary in RecipesPipeline.jl, assuming this value is suitable.