Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Require Requires #136

Closed
tbreloff opened this issue Feb 8, 2016 · 3 comments
Closed

RFC: Require Requires #136

tbreloff opened this issue Feb 8, 2016 · 3 comments

Comments

@tbreloff
Copy link
Member

tbreloff commented Feb 8, 2016

I'm considering adding https://github.com/one-more-minute/Requires.jl as a requirement for Plots. This will allow me to more easily add conditional functionality (DataFrames, FixedSizeArrays, etc) without requiring those packages for everyone. I take minimal package requirements seriously, so I wanted to throw it out there... does anyone think this is a bad idea?

@lobingera
Copy link

It's not a bad idea, and given the current state of julia import/require/dependency resolution it's inevitable use something like this.
I'd recommend to get Requires.jl closer to a regular julia package (like in julialang) and have more testing etc.

@Evizero
Copy link
Member

Evizero commented Feb 8, 2016

actually thought you already did it like that

@tbreloff
Copy link
Member Author

tbreloff commented Feb 9, 2016

This has been added.

@tbreloff tbreloff closed this as completed Feb 9, 2016
Jonas-a-Zimmermann pushed a commit to Jonas-a-Zimmermann/Plots.jl that referenced this issue Oct 29, 2024
fix JuliaPlots#121 : out of bound error with violin and boxplot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants