Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo that broke finalizers #541

Closed
wants to merge 1 commit into from
Closed

Conversation

amilsted
Copy link

@amilsted amilsted commented Aug 18, 2024

Caused finalizers to crash, which doesn't bring down Julia. Not the first time this is happened - guess we need to figure out how to catch this in tests!

@amilsted amilsted changed the title Fix a typo Fix a typo that broke finalizers Aug 21, 2024
@ericphanson
Copy link
Contributor

ah I didn't see this PR and created #544

@ericphanson ericphanson mentioned this pull request Aug 21, 2024
@amilsted
Copy link
Author

Yours is definitely better, as it ads a test!

@amilsted amilsted closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants