Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PyNULL typo #544

Merged
merged 2 commits into from
Aug 22, 2024
Merged

fix PyNULL typo #544

merged 2 commits into from
Aug 22, 2024

Conversation

ericphanson
Copy link
Contributor

@ericphanson ericphanson commented Aug 21, 2024

closes #543, closes #541

I added a test that would catch the issue:

julia> let arr = PyObjectArray([pylist([1]), pylist([2])])
                   PythonCall.JlWrap.pyobjectarray_finalizer(arr)
               end
ERROR: UndefVarError: `PYNULL` not defined
Stacktrace:
 [1] enqueue_all(ptrs::Vector{Ptr{PythonCall.C.PyObject}})
   @ PythonCall.GC ~/PythonCall.jl/src/GC/GC.jl:106
 [2] pyobjectarray_finalizer(x::PyObjectVector)
   @ PythonCall.JlWrap ~/PythonCall.jl/src/JlWrap/objectarray.jl:30
 [3] top-level scope
   @ REPL[17]:2

@cjdoris cjdoris merged commit 1ce2749 into JuliaPy:main Aug 22, 2024
13 checks passed
@cjdoris
Copy link
Collaborator

cjdoris commented Aug 22, 2024

Thanks! I simplified the test a bit and checked it still fails on main. I'll make a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V0.9.22 bug: error in running finalizer: UndefVarError(var=:PYNULL)
2 participants