Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change intersection of two lines to set operation #405

Closed
schillic opened this issue Jul 26, 2018 · 1 comment
Closed

Change intersection of two lines to set operation #405

schillic opened this issue Jul 26, 2018 · 1 comment
Assignees
@schillic
Labels
fix 🤕 Fix to a problem that is not too serious

Comments

@schillic
Copy link
Member

We have this concrete intersection function: intersection(L1::Line{N}, L2::Line{N})::Vector{N}.
The return value (a vector) is inconsistent with intersection operations for other set types.
Proposal: Return a Singleton (resp. an EmptySet).
@schillic schillic added discussion 🗣️ Requires human input fix 🤕 Fix to a problem that is not too serious labels Jul 26, 2018
@mforets
Copy link
Member

mforets commented Jul 26, 2018

👍

@schillic schillic removed the discussion 🗣️ Requires human input label Jul 26, 2018
@schillic schillic self-assigned this Jul 26, 2018
@schillic schillic mentioned this issue Jul 26, 2018
Merged
schillic added a commit that referenced this issue Jul 31, 2018
@schillic
Merge pull request #408 from JuliaReach/schillic/405
7c66417 
#405 - Change intersection of two lines to set operation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schillic schillic

Labels
fix 🤕 Fix to a problem that is not too serious
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schillic @mforets