#405 - Change intersection of two lines to set operation

[schillic]

Closes #405.

[kpotomkin]

Hi @schillic

1. Could we instead of

        # results in LAPACKException or SingularException if parallel	  
	        return Singleton(a \ b)
    catch

put

        # results in LAPACKException or SingularException if parallel	  
	        return Singleton(a \ b)
catch y
           if isa(y, LAPACKException) || isa(y, SingularException)

?

[schillic]

okay 👍

[mforets]

there are 2 failing doctests in concrete_intersection.jl.

for the one in LazySet.jl, rebase with master will fix it.

[mforets]

... and (later) we can move one step further and add a convex_hull that deals with a list of singletons (points), thus not needing these element(..). i think it would make the code a bit cleaner.

[schillic]

Hm, we could add an iterator type over Singletons that returns their vectors, say, Singleton2Vector, and pass Singleton2Vector(points) to convex_hull. However, if no convex hull shall be applied, we still need to unwrap them.

[schillic]

there are 2 failing doctests in concrete_intersection.jl.

Very good!

[mforets]

... ouch, that was unintended.

[mforets]

can be undone with $ git reset --hard HEAD~1

[mforets]

i lost your newer commits, sorry 😱

[schillic]

Hm? What did you do?

[mforets]

git push -f (-f for forced), i did this inadvertently, since i really wanted to pull your branch.

[schillic]

So this was only the fix of the doctests, right?

[mforets]

yes

[mforets]

i mean locally you have some commits that are not online, right?

[schillic]

Yep, I force-pushed again.

[schillic]

Can we remove the "Changes requested" review without the "Dismiss review" button?
EDIT: Nevermind, I just had to update the page...

[mforets]

in https://github.com/JuliaReach/LazySets.jl/pulls it now showsup as Approved.
i didnt click on dismiss Review. i think that i clicked on the Files Changed and then sent the (new) review.